Skip to content

Fix bug (incorrect witness addresses) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gberdyshev wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix bug (incorrect witness addresses) #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ac8c9e
Fix bug (incorrect witness addresses)
gberdyshev Sep 26, 2023
8d72c68
Fix bug x2
gberdyshev Sep 29, 2023
64961a8
Prepare to PyPi
gberdyshev Jan 3, 2024
b168f80
Update README.md
gberdyshev Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Pycryptotools, Python library for Crypto coins signatures and transactions

This is a fork of the Paul Martin library, which fixed a bug with displaying addresses of the Witness standard.
The following is a description of the original library:

This is a fork of Vitalik Buterin's original [pybitcointools](https://github.com/vbuterin/pybitcointools) library.

After a lot of work, the library is finally active again and being actively updated. This took a lot of work and unfortunately some backward imcompatible changes may have been introduced in v2. If you run into issues after upgrading open an issue and will try to help. If it's reasonable to do so we can consider restoring the previous behaviour in v2, otherwise will assist with migration.
Expand Down Expand Up @@ -620,4 +623,4 @@ not understanding what they were doing or because of bugs.
### Working together

If you wish to work together on crypto or other software related projects you can contact me using social links on my Github profile.
I can very easily and quickly build software tools on top of this pybitcointools library.
I can very easily and quickly build software tools on top of this pybitcointools library.
4 changes: 2 additions & 2 deletions cryptos/coins_async/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,12 +1067,12 @@ async def inspect(self, tx: Union[str, Tx]) -> TXInspectType:
i = _in['tx_pos']
prevout = (await anext(self.get_txs(h)))['outs'][i]
isum += prevout['value']
a = self.scripttoaddr(prevout['script'])
a = self.output_script_to_address(prevout['script'])
ins[a] = ins.get(a, 0) + prevout['value']
outs = []
osum = 0
for _out in tx['outs']:
outs.append({'address': self.scripttoaddr(_out['script']),
outs.append({'address': self.output_script_to_address(_out['script']),
'value': _out['value']})
osum += _out['value']
return {
Expand Down
8 changes: 4 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#!/usr/bin/env python
from setuptools import setup, find_packages

setup(name='cryptos',
setup(name='cryptos_witness',

@McLeanKing11 McLeanKing11 Jan 26, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0xb621ed75d5435012aa07f4fad865c2ed3a9850fbdacc0fcdf2ea262b4f697b01709d6ef5666add28c651dbec2b8748f5

version='2.0.9',
description='Python Crypto Coin Tools',
long_description=open('README.md').read(),
long_description_content_type='text/markdown',
author='Paul Martin',
author_email='greatestloginnameever@gmail.com',
url='http://github.com/primal100/pybitcointools',
author='gberdyshev',
author_email='bga20100@gmail.com',
url='https://github.com/gberdyshev/pybitcointools',
packages=find_packages(),
include_package_data=True,
install_requires=[
Expand Down