fix: use configured Gitlab URI for integration calls by default#135
Open
Kenneth-Sills wants to merge 1 commit into
Open
Conversation
Previously, all API calls on an OAuth Gitlab integration would still send their API calls to `gitlab.com`. Overriding that URI was only possible for PATs. This retargets the default for all Gitlab operations to the configured URI, which both fixes the integration _and_ has PAT integrations use a sane default. I considered saving the Gitlab URI used in the integration instead, which has the added benefit of preventing existing repository integrations from breaking if the admin retargets the global Gitlab URI setting. But that's a more opinionated approach more suitable for a maintainer to pursue, so left off for now. Easy enough to add later. :) Closes pricorephp#134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, all API calls on an OAuth Gitlab integration would still send their API calls to
gitlab.com. Overriding that URI was only possible for PATs.This retargets the default for all Gitlab operations to the configured URI, which both fixes the integration and has PAT integrations use a sane default.
I considered saving the Gitlab URI used in the integration instead, which has the added benefit of preventing existing repository integrations from breaking if the admin retargets the global Gitlab URI setting. But that's a more opinionated approach more suitable for a maintainer to pursue, so left off for now. Easy enough to add later. :)
Closes #134