Skip to content

fix: correct test map types to resolve PHPStan errors - #11

Closed
kimpepper wants to merge 1 commit into
mainfrom
fix/phpstan-test-map-types
Closed

kimpepper wants to merge 1 commit into
mainfrom
fix/phpstan-test-map-types

Conversation

@kimpepper

Copy link
Copy Markdown
Member

PHPStan fails because the test map's docblock types don't match the data it actually holds.

  • Adds TestMap PHPStan type aliases to TestMapper describing the real map shape
  • Uses the alias in getMap(), sortMap() and SplitterCommand::split()
  • Builds each class entry in getMap() from local variables, fixing the invalid += on the time total
  • Removes the now-unmatched entry from phpstan-baseline.neon

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Test Results

2 tests   2 ✅  0s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit 6b2d1d0.

♻️ This comment has been updated with latest results.

@kimpepper

kimpepper commented Nov 17, 2026 •

Copy link
Copy Markdown
Member Author

Closing because this repo is being archived.

@kimpepper kimpepper closed this Nov 17, 2026
@kimpepper
kimpepper deleted the fix/phpstan-test-map-types branch November 17, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant