Skip to content

fix: resolve phpstan errors from doctrine/dbal 4.6 deprecations - #42

Merged
kimpepper merged 1 commit into
mainfrom
fix/dbal-4.6-deprecations
Nov 17, 2026
Merged

kimpepper merged 1 commit into
mainfrom
fix/dbal-4.6-deprecations

Conversation

@kimpepper

Copy link
Copy Markdown
Member

doctrine/dbal 4.6 deprecated the schema-building methods we use, so phpstan now fails CI.

  • Builds the table with the dbal 4.5+ editor API (Table::editor(), Column::editor(), Index::editor()) when it exists, and falls back to the old Table methods on dbal 3 and 4.0–4.4; generated CREATE SQL is unchanged
  • drop() now uses the platform's getDropTableSQL(); it previously threw TableDoesNotExist instead of dropping the table
  • Removes an always-false $nodeKey == NULL check in Node

Use the dbal 4.5+ schema editor API when available, falling back to the
old Table methods on dbal 3 and 4.0-4.4. Drop the table via the
platform's DROP TABLE SQL, which also fixes drop() throwing
TableDoesNotExist. Remove an always-false null check in Node.
@kimpepper
kimpepper requested a review from larowlan November 17, 2026 06:45
@kimpepper
kimpepper merged commit c8a3f45 into main Nov 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants