Improved organization of pbench output directory and detection of duplicate stages in nested stages#59
Open
minhancao wants to merge 1 commit intoprestodb:mainfrom
Open
Conversation
9ef664f to
f0b961c
Compare
ethanyzhang
reviewed
Aug 29, 2025
0c29bc2 to
6b49b12
Compare
Contributor
Author
|
@ethanyzhang I have changed the implementation to the way that we discussed and also improved on the checkStageLinks() to detect for duplicate stages in nested stages. Please review when you can, thanks! |
…licate stages in nested stages.
6b49b12 to
fdb5e72
Compare
ethanyzhang
requested changes
Sep 9, 2025
|
|
||
| nextStageMap := make(map[string]bool) | ||
| for _, nextStage := range stage.NextStages { | ||
| if nextStage == nil { |
Collaborator
There was a problem hiding this comment.
If it is nil, you probably want to error out right?
| utils.PrepareOutputDirectory(stageOutputPath) | ||
|
|
||
| // Recursively call the function on the child stage | ||
| nextStage.createNextStagesOutputDirectories() |
Collaborator
There was a problem hiding this comment.
Why? when the next stage is run, it will call this again right?
6f32a1a to
b8de6a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved organization of pbench output directory to navigate easier for streams runs.
Example 3 streams run:
pbench command ran:
3streams.json:
tpch_stream1.json:
tpch_stream2.json, tpch_stream3.json:
tpch_stream1_child.json: