Add Hapi.js middleware#2
Open
Lasalot wants to merge 8 commits into
Open
Conversation
Comment on lines
+20
to
+21
| "url": "git://github.com/prerender/integrations", | ||
| "directory": "prerender-hapi" |
There was a problem hiding this comment.
mmm shouldn't it be prerender/hapi?
Comment on lines
+62
to
+64
| if (settings.token) { | ||
| headers['X-Prerender-Token'] = settings.token; | ||
| } |
There was a problem hiding this comment.
maybe we can log a warning here, could be useful to debug for the client.
Adds fail-fast: false and npm cache for parity with koa workflow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Lets the backend correlate requests with a specific integration version and uniquely identify each request for support triage. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Asserts the outgoing wire-protocol shape (URL composition, required and optional headers, X-Prerender-Int-Type value, Int-Version semver, Request-Id UUID format and per-request uniqueness, query-string preservation) — surfaces that the existing smoke tests don't cover. Mock server lives at prerender/integration-contract and is fetched in CI before tests run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of the Prerender.io integration for hapi.