Set object to "chat.completion" for non-streaming chat completions#788
Open
lollinng wants to merge 1 commit into
Open
Set object to "chat.completion" for non-streaming chat completions#788lollinng wants to merge 1 commit into
lollinng wants to merge 1 commit into
Conversation
The non-streaming /v1/chat/completions response set object to "text_completion" instead of "chat.completion" (the value the OpenAI API returns, and consistent with the streaming chunk's "chat.completion.chunk"). This broke OpenAI-compatible clients that branch on the object type. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ChatCompletionResponse::new(non-streaming/v1/chat/completions) hardcodes:Per the OpenAI API, a non-streaming chat completion has
object: "chat.completion"("text_completion"is the legacy/v1/completionsobject). The streaming path in the same file already uses the correct"chat.completion.chunk", so this is an inconsistency: OpenAI-compatible clients that branch onobjectget the wrong type from the non-streaming chat endpoint.Fix
Set
objectto"chat.completion"for the non-streaming chat response. The twoCompletionResponseconstructions (the/v1/completionsendpoint) keep"text_completion", which is correct.