You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make preact/compat’s flushSync batch updates performed inside its callback.
Previously, flushSync temporarily configured options.debounceRendering to execute every scheduled render immediately. This made updates synchronous, but it also caused each state setter to render independently:
flushSync(()=>{setA(1);setB(1);});
The example above could render twice instead of batching both updates into one synchronous commit.
This change captures the scheduled render callback while the user callback runs, then flushes it once before returning. The previous debounce function is restored in a finally block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
preact/compat’sflushSyncbatch updates performed inside its callback.Previously,
flushSynctemporarily configuredoptions.debounceRenderingto execute every scheduled render immediately. This made updates synchronous, but it also caused each state setter to render independently:The example above could render twice instead of batching both updates into one synchronous commit.
This change captures the scheduled render callback while the user callback runs, then flushes it once before returning. The previous debounce function is restored in a
finallyblock.Results
Measured with Octane’s nested update benchmark:
Non-batched update timings remain unchanged.