Add reorder1k benchmark#17
Merged
Merged
Conversation
Measures moving the first 3 of 1,000 keyed rows to the end of the list (3 warmup runs plus a measured run). This displacement pattern is the worst case for reconciliation heuristics that only handle shifts: the whole suffix gets moved instead of the short displaced prefix. Adds a displace(n) mutation to the shared store and exposes it from the preact, preact-class, and preact-hooks table-app implementations.
This was referenced Jul 22, 2026
The lockfile pins whatever chromedriver major was current when it was last refreshed (131 right now), while the CI runner image ships a newer Chrome (150). detect_chromedriver_version makes the chromedriver package download the driver matching the installed browser, so the two can no longer drift apart.
marvinhagemeister
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
reorder1kbenchmark to the table-app suite: it renders 1,000 keyed rows, then measures moving the first 3 rows to the end of the list (3 warmup runs + 1 measured run, asserting row order between runs).Why
This displacement pattern is a worst case for reconciliation heuristics that only recognize shift patterns: instead of moving the 3 displaced rows, the reconciler moves the entire 997-row suffix. None of the existing benchmarks exercise it —
swapRowsis excluded from the pathological path by design, andmany-updates/update10th1kdon't reorder at all.It directly motivates preactjs/preact#5172 and the v11 minimal-moves work; current numbers on v10.x (Chrome 150, headless, tachometer):
How
store.displace(n)added to the shared table-app storedisplacefrom thepreact,preact-class, andpreact-hooksimplementations (preact-signalsis currently a counter stub, so it was left alone)apps/table-app/reorder1k.htmlmodeled afterupdate10th1k.html