Skip to content

Fix setup from a raw V commit - #1

Open
antono3 wants to merge 1 commit into
prantlf:masterfrom
antono3:fix/commit-version-resolution
Open

antono3 wants to merge 1 commit into
prantlf:masterfrom
antono3:fix/commit-version-resolution

Conversation

@antono3

@antono3 antono3 commented Sep 12, 2026

Copy link
Copy Markdown

Summary

  • pass a raw V revision to getCommit as the commit SHA, keeping the token in the authorization position
  • make the source-archive mock use its actual content directory
  • exercise a complete mocked install from a raw commit
  • run the test action without an intermediate shell so hyphenated action input variables survive on Node 24

This fixes raw commit inputs such as version: 5ff8ecb55f6709fd7e6f645ef7779383f30c47c0, which currently put the token in the GitHub API path and the revision in the authorization header, producing a 401 response.

Verification

  • pnpm run build
  • pnpm test with Node.js 24.19.0

Comment thread src/index.js
Comment thread src/index.js
@prantlf

prantlf commented Sep 13, 2026

Copy link
Copy Markdown
Owner

That you for your contribution! It looks like there's a problem with building V and copying to other directory. Embedded files are missing? I tried your branch in another branch with upgraded dependencies, but the error remains: https://github.com/prantlf/setup-v-action/actions/runs/34755264324/

@antono3
antono3 force-pushed the fix/commit-version-resolution branch from 36f23d0 to 85ad339 Compare September 13, 2026 16:27
@antono3

antono3 commented Sep 13, 2026

Copy link
Copy Markdown
Author

Thanks for reproducing this. The failure is caused by V embedding build-time resource paths: the action built in the full-SHA directory, moved selected files to the shortened install directory, and then deleted the directory referenced by the compiler.

I rebased the PR onto current master and updated it so source installations move the complete source tree to the final shortened path before running make. Release-archive installation remains unchanged. The mock test now also verifies that the source tree is retained, and the forced-build action checks are enabled on Linux and macOS so they execute the installed compiler and cover this exact failure.

The update also uses v version instead of v -V (current V master no longer accepts -V) and reads the raw commit date from commit.author.date.

Local pnpm test, pnpm run build, and a real source build of the exact failing V revision (1ac804356e649e6c1b915014cba5097142e40fe8) all pass from the relocated directory. The current PR workflow is waiting for maintainer approval because it changes .github/workflows/ci.yml: https://github.com/prantlf/setup-v-action/actions/runs/34768993136

@antono3
antono3 force-pushed the fix/commit-version-resolution branch from 85ad339 to 344f898 Compare September 13, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants