Skip to content

Conversation

@willieyz
Copy link
Contributor

@willieyz willieyz commented Jan 23, 2026

Add unit tests for keccakf1600 x1 and x4 permutation functions that
compare native implementations against the C reference implementation.

  • test_keccakf1600_permute: tests x1 permutation when
    MLD_USE_FIPS202_X1_NATIVE
  • test_keccakf1600x4_permute: tests x4 permutation when
    MLD_USE_FIPS202_X4_NATIVE
  • Expose mld_keccakf1600_permute_c via MLD_STATIC_TESTABLE for testing

@willieyz willieyz marked this pull request as ready for review January 23, 2026 02:42
@willieyz willieyz requested a review from a team as a code owner January 23, 2026 02:42
@oqs-bot
Copy link
Contributor

oqs-bot commented Jan 23, 2026

CBMC Results (ML-DSA-44)

Full Results (173 proofs)
Proof Status Current Previous Change
**TOTAL** 1824s 1885s -3.2%
mld_attempt_signature_generation 220s 231s -5%
polyvecl_pointwise_acc_montgomery_c 201s 204s -1%
poly_pointwise_montgomery_c 125s 133s -6%
rej_uniform_native 125s 122s +2%
sign_verify_internal 119s 118s +1%
mld_ct_memcmp 79s 82s -4%
mld_invntt_layer 71s 74s -4%
keccak_squeezeblocks_x4 43s 45s -4%
mld_ntt_layer 43s 47s -9%
sign_signature_internal 34s 36s -6%
rej_uniform 20s 22s -9%
fqmul 19s 20s -5%
poly_chknorm_c 17s 18s -6%
poly_uniform_eta_4x 17s 16s +6%
rej_uniform_c 16s 16s +0%
polyeta_unpack 15s 13s +15%
poly_uniform_4x 14s 15s -7%
polyt0_unpack 14s 16s -12%
polyvec_matrix_expand 14s 16s -12%
mld_compute_t0_t1_tr_from_sk_components 13s 15s -13%
polymat_permute_bitrev_to_custom 13s 15s -13%
keccak_absorb_once_x4 12s 12s +0%
keccakf1600x4_permute_native 12s 12s +0%
mld_ntt_butterfly_block 12s 11s +9%
polyz_unpack_c 10s 11s -9%
poly_invntt_tomont_c 9s 11s -18%
polyveck_add 9s 9s +0%
keccakf1600_permute_native 8s 10s -20%
mld_polyvecl_permute_bitrev_to_custom_native 8s 11s -27%
mld_check_pct 7s 6s +17%
poly_decompose_c 7s 3s +133%
polyvec_matrix_expand_serial 7s 5s +40%
polyveck_pointwise_poly_montgomery 7s 5s +40%
keccakf1600_permute 6s 8s -25%
montgomery_reduce 6s 2s +200%
poly_decompose_native 6s 3s +100%
poly_uniform 6s 5s +20%
poly_uniform_eta 6s 5s +20%
polyvec_matrix_pointwise_montgomery 6s 4s +50%
polyveck_pack_eta 6s 4s +50%
polyveck_power2round 6s 4s +50%
polyvecl_chknorm 6s 5s +20%
polyz_unpack_native 6s 2s +200%
rej_eta_c 6s 5s +20%
sign_open 6s 4s +50%
sign_pk_from_sk 6s 6s +0%
sign_signature_pre_hash_shake256 6s 4s +50%
sign_verify_pre_hash_internal 6s 3s +100%
unpack_hints 6s 7s -14%
keccak_absorb 5s 7s -29%
keccak_squeeze 5s 3s +67%
mld_compute_pack_z 5s 7s -29%
poly_make_hint 5s 4s +25%
poly_ntt 5s 2s +150%
poly_uniform_gamma1 5s 4s +25%
poly_use_hint_c 5s 3s +67%
polyveck_caddq 5s 6s -17%
polyveck_decompose 5s 5s +0%
polyveck_sub 5s 4s +25%
polyvecl_pointwise_acc_montgomery 5s 6s -17%
polyvecl_unpack_z 5s 5s +0%
sign_keypair_internal 5s 6s -17%
caddq 4s 2s +100%
keccakf1600x4_permute 4s 2s +100%
mld_ct_abs_i32 4s 3s +33%
mld_ct_cmask_neg_i32 4s 3s +33%
mld_h 4s 5s -20%
mld_prepare_domain_separation_prefix 4s 4s +0%
mld_sample_s1_s2 4s 5s -20%
poly_challenge 4s 3s +33%
poly_invntt_tomont_native 4s 2s +100%
poly_ntt_native 4s 6s -33%
poly_power2round 4s 2s +100%
poly_sub 4s 4s +0%
poly_uniform_gamma1_4x 4s 3s +33%
poly_use_hint_native 4s 3s +33%
polyt0_pack 4s 4s +0%
polyveck_invntt_tomont 4s 6s -33%
polyveck_make_hint 4s 5s -20%
polyveck_ntt 4s 5s -20%
polyveck_pack_t0 4s 4s +0%
polyveck_pack_w1 4s 4s +0%
polyveck_shiftl 4s 4s +0%
polyvecl_ntt 4s 5s -20%
polyvecl_permute_bitrev_to_custom 4s 3s +33%
polyvecl_pointwise_acc_montgomery_native 4s 5s -20%
polyvecl_uniform_gamma1 4s 2s +100%
reduce32 4s 3s +33%
rej_eta_native 4s 3s +33%
shake256_squeeze 4s 3s +33%
shake256x4_absorb_once 4s 2s +100%
sign 4s 8s -50%
sign_keypair 4s 4s +0%
sign_verify_extmu 4s 5s -20%
unpack_sk 4s 4s +0%
decompose 3s 2s +50%
keccakf1600_extract_bytes (big endian) 3s 2s +50%
keccakf1600_xor_bytes 3s 4s -25%
keccakf1600x4_extract_bytes 3s 2s +50%
mld_ct_cmask_nonzero_u8 3s 3s +0%
mld_ct_get_optblocker_i64 3s 2s +50%
mld_ct_get_optblocker_u32 3s 2s +50%
mld_keccakf1600_extract_bytes 3s 3s +0%
mld_sample_s1_s2_serial 3s 3s +0%
mld_value_barrier_u32 3s 5s -40%
ntt_native_x86_64 3s 5s -40%
pack_pk 3s 2s +50%
pack_sig_z 3s 5s -40%
pack_sk 3s 5s -40%
poly_caddq 3s 4s -25%
poly_chknorm_native 3s 3s +0%
poly_decompose 3s 3s +0%
poly_ntt_c 3s 4s -25%
poly_pointwise_montgomery_native 3s 4s -25%
poly_reduce 3s 3s +0%
poly_use_hint 3s 2s +50%
polyeta_pack 3s 3s +0%
polyt1_unpack 3s 2s +50%
polyveck_chknorm 3s 3s +0%
polyveck_reduce 3s 4s -25%
polyveck_unpack_eta 3s 4s -25%
polyveck_unpack_t0 3s 3s +0%
polyveck_use_hint 3s 4s -25%
polyvecl_pack_eta 3s 3s +0%
rej_eta 3s 4s -25%
shake128_release 3s 3s +0%
shake128_squeeze 3s 2s +50%
shake128x4_absorb_once 3s 3s +0%
shake128x4_squeezeblocks 3s 2s +50%
shake256_finalize 3s 3s +0%
shake256_init 3s 1s +200%
sign_signature 3s 6s -50%
sign_signature_extmu 3s 3s +0%
sign_signature_pre_hash_internal 3s 5s -40%
sign_verify 3s 5s -40%
sign_verify_pre_hash_shake256 3s 5s -40%
unpack_pk 3s 2s +50%
fqscale 2s 4s -50%
keccak_finalize 2s 3s -33%
keccakf1600_xor_bytes (big endian) 2s 3s -33%
make_hint 2s 4s -50%
mld_ct_cmask_nonzero_u32 2s 4s -50%
mld_value_barrier_i64 2s 2s +0%
mld_value_barrier_u8 2s 1s +100%
pack_sig_c_h 2s 2s +0%
poly_add 2s 4s -50%
poly_caddq_c 2s 3s -33%
poly_caddq_native 2s 4s -50%
poly_chknorm 2s 4s -50%
poly_invntt_tomont 2s 4s -50%
poly_shiftl 2s 3s -33%
polyt1_pack 2s 4s -50%
polyvecl_uniform_gamma1_serial 2s 4s -50%
polyvecl_unpack_eta 2s 1s +100%
polyw1_pack 2s 2s +0%
polyz_pack 2s 3s -33%
polyz_unpack 2s 2s +0%
power2round 2s 4s -50%
shake128_absorb 2s 2s +0%
shake128_init 2s 2s +0%
shake256 2s 3s -33%
shake256_absorb 2s 5s -60%
shake256_release 2s 1s +100%
sys_check_capability 2s 4s -50%
unpack_sig 2s 3s -33%
use_hint 2s 3s -33%
keccak_init 1s 1s +0%
keccakf1600x4_xor_bytes 1s 2s -50%
mld_ct_get_optblocker_u8 1s 4s -75%
mld_ct_sel_int32 1s 3s -67%
poly_pointwise_montgomery 1s 4s -75%
shake128_finalize 1s 5s -80%
shake256x4_squeezeblocks 1s 1s +0%

@oqs-bot
Copy link
Contributor

oqs-bot commented Jan 23, 2026

CBMC Results (ML-DSA-65)

Full Results (173 proofs)
Proof Status Current Previous Change
**TOTAL** 2499s 2326s +7.4%
mld_attempt_signature_generation 422s 394s +7%
polyvecl_pointwise_acc_montgomery_c 262s 213s +23%
sign_verify_internal 177s 166s +7%
poly_pointwise_montgomery_c 160s 126s +27%
rej_uniform_native 138s 128s +8%
polyvec_matrix_expand 135s 131s +3%
mld_ct_memcmp 89s 79s +13%
polyvec_matrix_expand_serial 66s 65s +2%
mld_invntt_layer 63s 59s +7%
sign_signature_internal 53s 49s +8%
mld_ntt_layer 46s 44s +5%
keccak_squeezeblocks_x4 44s 42s +5%
mld_compute_t0_t1_tr_from_sk_components 25s 24s +4%
fqmul 20s 20s +0%
polymat_permute_bitrev_to_custom 20s 18s +11%
rej_uniform 20s 20s +0%
poly_uniform_eta_4x 19s 18s +6%
rej_uniform_c 18s 19s -5%
polyvec_matrix_pointwise_montgomery 17s 14s +21%
polyt0_unpack 16s 15s +7%
polyveck_decompose 16s 16s +0%
poly_uniform_4x 15s 13s +15%
poly_chknorm_c 14s 11s +27%
keccak_absorb_once_x4 12s 13s -8%
keccakf1600x4_permute_native 12s 13s -8%
mld_ntt_butterfly_block 12s 14s -14%
polyveck_use_hint 12s 14s -14%
sign 12s 10s +20%
poly_invntt_tomont_c 11s 9s +22%
mld_check_pct 10s 9s +11%
polyveck_add 10s 8s +25%
polyveck_shiftl 10s 8s +25%
sign_pk_from_sk 10s 8s +25%
polyveck_invntt_tomont 9s 8s +12%
polyveck_ntt 9s 9s +0%
polyveck_power2round 9s 7s +29%
mld_compute_pack_z 8s 6s +33%
mld_polyvecl_permute_bitrev_to_custom_native 8s 9s -11%
polyveck_caddq 8s 9s -11%
polyveck_reduce 8s 7s +14%
sign_keypair_internal 8s 7s +14%
keccakf1600_permute 7s 8s -12%
keccakf1600_permute_native 7s 9s -22%
mld_h 7s 4s +75%
poly_decompose_c 7s 8s -12%
poly_use_hint_c 7s 5s +40%
polyeta_unpack 7s 8s -12%
polyveck_sub 7s 8s -12%
poly_uniform 6s 4s +50%
polyveck_make_hint 6s 4s +50%
polyvecl_ntt 6s 6s +0%
polyz_unpack_c 6s 5s +20%
rej_eta_c 6s 3s +100%
sign_verify_pre_hash_shake256 6s 4s +50%
unpack_hints 6s 4s +50%
mld_ct_cmask_nonzero_u32 5s 2s +150%
mld_sample_s1_s2_serial 5s 4s +25%
ntt_native_x86_64 5s 4s +25%
poly_add 5s 5s +0%
poly_challenge 5s 4s +25%
poly_invntt_tomont 5s 3s +67%
poly_invntt_tomont_native 5s 5s +0%
poly_pointwise_montgomery_native 5s 4s +25%
poly_reduce 5s 3s +67%
poly_uniform_eta 5s 5s +0%
poly_uniform_gamma1_4x 5s 4s +25%
polyveck_chknorm 5s 4s +25%
polyveck_pointwise_poly_montgomery 5s 7s -29%
polyvecl_pack_eta 5s 3s +67%
rej_eta_native 5s 5s +0%
shake256_init 5s 3s +67%
sign_signature_extmu 5s 4s +25%
sign_verify_pre_hash_internal 5s 4s +25%
decompose 4s 3s +33%
keccak_absorb 4s 6s -33%
keccakf1600_xor_bytes 4s 3s +33%
keccakf1600x4_permute 4s 4s +0%
mld_sample_s1_s2 4s 6s -33%
pack_pk 4s 3s +33%
pack_sig_z 4s 3s +33%
poly_caddq 4s 2s +100%
poly_decompose_native 4s 3s +33%
poly_ntt 4s 3s +33%
poly_uniform_gamma1 4s 2s +100%
polyeta_pack 4s 3s +33%
polyt0_pack 4s 5s -20%
polyveck_pack_eta 4s 3s +33%
polyvecl_chknorm 4s 5s -20%
polyvecl_permute_bitrev_to_custom 4s 2s +100%
polyvecl_pointwise_acc_montgomery_native 4s 3s +33%
rej_eta 4s 4s +0%
shake128x4_absorb_once 4s 4s +0%
shake256 4s 4s +0%
shake256_squeeze 4s 1s +300%
shake256x4_squeezeblocks 4s 4s +0%
sign_verify 4s 3s +33%
sys_check_capability 4s 3s +33%
unpack_pk 4s 2s +100%
unpack_sig 4s 3s +33%
use_hint 4s 3s +33%
fqscale 3s 4s -25%
keccakf1600_extract_bytes (big endian) 3s 5s -40%
keccakf1600x4_xor_bytes 3s 4s -25%
make_hint 3s 2s +50%
mld_ct_cmask_neg_i32 3s 2s +50%
mld_ct_get_optblocker_u32 3s 2s +50%
mld_ct_get_optblocker_u8 3s 4s -25%
mld_ct_sel_int32 3s 4s -25%
mld_prepare_domain_separation_prefix 3s 5s -40%
poly_caddq_native 3s 4s -25%
poly_chknorm_native 3s 5s -40%
poly_make_hint 3s 4s -25%
poly_ntt_c 3s 3s +0%
poly_ntt_native 3s 2s +50%
poly_power2round 3s 5s -40%
poly_shiftl 3s 3s +0%
poly_use_hint 3s 3s +0%
poly_use_hint_native 3s 5s -40%
polyt1_pack 3s 2s +50%
polyt1_unpack 3s 2s +50%
polyveck_unpack_eta 3s 3s +0%
polyvecl_unpack_eta 3s 4s -25%
polyvecl_unpack_z 3s 3s +0%
polyz_pack 3s 6s -50%
polyz_unpack 3s 3s +0%
polyz_unpack_native 3s 3s +0%
shake128_absorb 3s 1s +200%
shake128_init 3s 1s +200%
shake128_release 3s 3s +0%
shake128_squeeze 3s 3s +0%
shake128x4_squeezeblocks 3s 3s +0%
shake256_absorb 3s 2s +50%
shake256x4_absorb_once 3s 3s +0%
sign_keypair 3s 4s -25%
sign_open 3s 5s -40%
sign_signature 3s 6s -50%
sign_signature_pre_hash_shake256 3s 3s +0%
unpack_sk 3s 6s -50%
caddq 2s 2s +0%
keccak_finalize 2s 2s +0%
keccak_init 2s 4s -50%
keccak_squeeze 2s 3s -33%
keccakf1600_xor_bytes (big endian) 2s 2s +0%
mld_ct_abs_i32 2s 1s +100%
mld_ct_cmask_nonzero_u8 2s 3s -33%
mld_ct_get_optblocker_i64 2s 1s +100%
mld_value_barrier_i64 2s 1s +100%
montgomery_reduce 2s 4s -50%
pack_sig_c_h 2s 2s +0%
pack_sk 2s 3s -33%
poly_caddq_c 2s 5s -60%
poly_chknorm 2s 3s -33%
poly_decompose 2s 3s -33%
poly_pointwise_montgomery 2s 2s +0%
polyveck_pack_t0 2s 2s +0%
polyveck_pack_w1 2s 2s +0%
polyveck_unpack_t0 2s 3s -33%
polyvecl_pointwise_acc_montgomery 2s 4s -50%
polyvecl_uniform_gamma1 2s 6s -67%
polyvecl_uniform_gamma1_serial 2s 2s +0%
polyw1_pack 2s 3s -33%
power2round 2s 4s -50%
reduce32 2s 4s -50%
shake256_release 2s 3s -33%
sign_signature_pre_hash_internal 2s 3s -33%
sign_verify_extmu 2s 4s -50%
keccakf1600x4_extract_bytes 1s 2s -50%
mld_keccakf1600_extract_bytes 1s 1s +0%
mld_value_barrier_u32 1s 3s -67%
mld_value_barrier_u8 1s 3s -67%
poly_sub 1s 2s -50%
shake128_finalize 1s 3s -67%
shake256_finalize 1s 4s -75%

@oqs-bot
Copy link
Contributor

oqs-bot commented Jan 23, 2026

CBMC Results (ML-DSA-87)

Full Results (173 proofs)
Proof Status Current Previous Change
**TOTAL** 2273s 2197s +3.5%
mld_attempt_signature_generation 205s 200s +2%
polyvec_matrix_expand 194s 192s +1%
polyvecl_pointwise_acc_montgomery_c 178s 181s -2%
poly_pointwise_montgomery_c 145s 138s +5%
rej_uniform_native 134s 128s +5%
sign_verify_internal 124s 119s +4%
polyvec_matrix_expand_serial 107s 104s +3%
mld_ct_memcmp 86s 78s +10%
mld_invntt_layer 64s 62s +3%
sign_signature_internal 58s 60s -3%
mld_ntt_layer 47s 43s +9%
keccak_squeezeblocks_x4 44s 44s +0%
mld_compute_t0_t1_tr_from_sk_components 28s 25s +12%
polymat_permute_bitrev_to_custom 25s 23s +9%
fqmul 21s 19s +11%
poly_uniform_eta_4x 19s 17s +12%
rej_uniform 19s 20s -5%
rej_uniform_c 19s 17s +12%
poly_chknorm_c 18s 16s +12%
polyt0_unpack 16s 13s +23%
poly_uniform_4x 15s 15s +0%
polyvec_matrix_pointwise_montgomery 15s 14s +7%
polyveck_add 15s 17s -12%
polyveck_power2round 14s 13s +8%
polyeta_unpack 13s 15s -13%
keccak_absorb_once_x4 12s 12s +0%
keccakf1600x4_permute_native 12s 12s +0%
mld_ntt_butterfly_block 12s 10s +20%
polyveck_chknorm 11s 7s +57%
keccakf1600_permute 10s 10s +0%
keccakf1600_permute_native 10s 7s +43%
mld_check_pct 10s 9s +11%
mld_polyvecl_permute_bitrev_to_custom_native 10s 8s +25%
polyveck_reduce 10s 8s +25%
sign 10s 8s +25%
sign_pk_from_sk 10s 10s +0%
poly_invntt_tomont_c 9s 12s -25%
polyveck_caddq 9s 8s +12%
polyveck_ntt 9s 9s +0%
polyveck_pointwise_poly_montgomery 9s 7s +29%
polyveck_use_hint 9s 8s +12%
poly_decompose_c 8s 8s +0%
unpack_hints 8s 5s +60%
keccak_absorb 7s 7s +0%
mld_compute_pack_z 7s 5s +40%
polyveck_invntt_tomont 7s 8s -12%
polyveck_sub 7s 9s -22%
polyveck_unpack_eta 7s 6s +17%
polyvecl_ntt 7s 11s -36%
sign_verify 7s 3s +133%
mld_h 6s 4s +50%
mld_sample_s1_s2 6s 6s +0%
mld_sample_s1_s2_serial 6s 6s +0%
polyt0_pack 6s 5s +20%
polyveck_decompose 6s 6s +0%
polyveck_make_hint 6s 2s +200%
polyveck_shiftl 6s 7s -14%
rej_eta_c 6s 5s +20%
rej_eta_native 6s 5s +20%
sign_keypair_internal 6s 4s +50%
sign_open 6s 5s +20%
sign_signature 6s 4s +50%
sign_verify_extmu 6s 6s +0%
keccakf1600x4_extract_bytes 5s 2s +150%
pack_pk 5s 2s +150%
pack_sig_c_h 5s 5s +0%
poly_add 5s 4s +25%
poly_caddq 5s 3s +67%
poly_challenge 5s 6s -17%
poly_decompose 5s 3s +67%
poly_pointwise_montgomery_native 5s 3s +67%
poly_use_hint 5s 5s +0%
poly_use_hint_native 5s 3s +67%
polyt1_pack 5s 4s +25%
polyveck_unpack_t0 5s 2s +150%
polyvecl_uniform_gamma1_serial 5s 3s +67%
polyz_unpack_c 5s 4s +25%
shake128_absorb 5s 3s +67%
sign_keypair 5s 4s +25%
unpack_sk 5s 6s -17%
fqscale 4s 3s +33%
keccak_finalize 4s 1s +300%
keccakf1600_xor_bytes 4s 2s +100%
keccakf1600_xor_bytes (big endian) 4s 3s +33%
mld_keccakf1600_extract_bytes 4s 4s +0%
mld_prepare_domain_separation_prefix 4s 3s +33%
montgomery_reduce 4s 3s +33%
pack_sk 4s 4s +0%
poly_caddq_c 4s 3s +33%
poly_power2round 4s 2s +100%
poly_uniform_eta 4s 4s +0%
poly_uniform_gamma1_4x 4s 3s +33%
polyeta_pack 4s 2s +100%
polyvecl_permute_bitrev_to_custom 4s 6s -33%
polyvecl_pointwise_acc_montgomery_native 4s 3s +33%
polyvecl_uniform_gamma1 4s 2s +100%
polyvecl_unpack_eta 4s 6s -33%
polyw1_pack 4s 5s -20%
shake256 4s 3s +33%
shake256x4_absorb_once 4s 2s +100%
sign_signature_pre_hash_internal 4s 3s +33%
sign_signature_pre_hash_shake256 4s 6s -33%
sign_verify_pre_hash_shake256 4s 4s +0%
decompose 3s 3s +0%
keccak_squeeze 3s 3s +0%
keccakf1600_extract_bytes (big endian) 3s 3s +0%
keccakf1600x4_xor_bytes 3s 2s +50%
make_hint 3s 3s +0%
mld_ct_abs_i32 3s 3s +0%
mld_ct_cmask_nonzero_u8 3s 2s +50%
mld_ct_get_optblocker_u8 3s 4s -25%
mld_value_barrier_u32 3s 2s +50%
poly_caddq_native 3s 3s +0%
poly_chknorm 3s 4s -25%
poly_chknorm_native 3s 2s +50%
poly_invntt_tomont_native 3s 4s -25%
poly_ntt 3s 2s +50%
poly_ntt_c 3s 3s +0%
poly_ntt_native 3s 4s -25%
poly_reduce 3s 4s -25%
poly_shiftl 3s 3s +0%
poly_sub 3s 4s -25%
poly_uniform_gamma1 3s 4s -25%
polyvecl_chknorm 3s 4s -25%
polyvecl_pack_eta 3s 4s -25%
polyvecl_unpack_z 3s 5s -40%
polyz_pack 3s 2s +50%
reduce32 3s 3s +0%
shake128x4_absorb_once 3s 2s +50%
shake256_finalize 3s 2s +50%
shake256x4_squeezeblocks 3s 3s +0%
sign_verify_pre_hash_internal 3s 5s -40%
sys_check_capability 3s 4s -25%
unpack_pk 3s 3s +0%
use_hint 3s 4s -25%
caddq 2s 6s -67%
keccakf1600x4_permute 2s 2s +0%
mld_ct_cmask_nonzero_u32 2s 1s +100%
mld_ct_get_optblocker_i64 2s 4s -50%
mld_ct_get_optblocker_u32 2s 2s +0%
mld_value_barrier_i64 2s 3s -33%
mld_value_barrier_u8 2s 2s +0%
ntt_native_x86_64 2s 3s -33%
pack_sig_z 2s 3s -33%
poly_decompose_native 2s 2s +0%
poly_invntt_tomont 2s 3s -33%
poly_make_hint 2s 5s -60%
poly_pointwise_montgomery 2s 4s -50%
poly_uniform 2s 4s -50%
poly_use_hint_c 2s 3s -33%
polyt1_unpack 2s 3s -33%
polyveck_pack_eta 2s 2s +0%
polyveck_pack_w1 2s 4s -50%
polyvecl_pointwise_acc_montgomery 2s 5s -60%
polyz_unpack 2s 4s -50%
polyz_unpack_native 2s 2s +0%
power2round 2s 2s +0%
rej_eta 2s 3s -33%
shake128_finalize 2s 3s -33%
shake128_init 2s 1s +100%
shake128_release 2s 3s -33%
shake128_squeeze 2s 4s -50%
shake128x4_squeezeblocks 2s 2s +0%
shake256_absorb 2s 2s +0%
shake256_init 2s 1s +100%
shake256_release 2s 4s -50%
shake256_squeeze 2s 2s +0%
sign_signature_extmu 2s 2s +0%
unpack_sig 2s 4s -50%
keccak_init 1s 2s -50%
mld_ct_cmask_neg_i32 1s 1s +0%
mld_ct_sel_int32 1s 3s -67%
polyveck_pack_t0 1s 4s -75%

Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only part of the changes were ported, and NUM_RANDOM_TESTS was changed in the wrong way.
I'll fix it myself shortly.

Add unit tests for keccakf1600 x1 and x4 permutation functions that
compare native implementations against the C reference implementation.

- test_keccakf1600_permute: tests x1 permutation when
  MLD_USE_FIPS202_X1_NATIVE
- test_keccakf1600x4_permute: tests x4 permutation when
  MLD_USE_FIPS202_X4_NATIVE
- Expose mld_keccakf1600_permute_c via MLD_STATIC_TESTABLE for testing

Signed-off-by: willieyz <willie.zhao@chelpis.com>
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the two mistakes myself.

@hanno-becker hanno-becker merged commit 6b9788a into main Jan 25, 2026
337 checks passed
@hanno-becker hanno-becker deleted the keccak-unit branch January 25, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port: Unit tests: Add native Keccak x1 and x4 tests

5 participants