-
Notifications
You must be signed in to change notification settings - Fork 35
Port: Unit tests: Add native Keccak x1 and x4 tests #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CBMC Results (ML-DSA-44)Full Results (173 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (173 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (173 proofs)
|
mkannwischer
requested changes
Jan 25, 2026
Contributor
mkannwischer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only part of the changes were ported, and NUM_RANDOM_TESTS was changed in the wrong way.
I'll fix it myself shortly.
Add unit tests for keccakf1600 x1 and x4 permutation functions that compare native implementations against the C reference implementation. - test_keccakf1600_permute: tests x1 permutation when MLD_USE_FIPS202_X1_NATIVE - test_keccakf1600x4_permute: tests x4 permutation when MLD_USE_FIPS202_X4_NATIVE - Expose mld_keccakf1600_permute_c via MLD_STATIC_TESTABLE for testing Signed-off-by: willieyz <willie.zhao@chelpis.com>
523b8dc to
c0941ae
Compare
mkannwischer
approved these changes
Jan 25, 2026
Contributor
mkannwischer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the two mistakes myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for keccakf1600 x1 and x4 permutation functions that
compare native implementations against the C reference implementation.
MLD_USE_FIPS202_X1_NATIVE
MLD_USE_FIPS202_X4_NATIVE