Skip to content

Conversation

@willieyz
Copy link
Contributor

@willieyz willieyz commented Jan 16, 2026

  • Resolves: Eliminate SUPERCOP API from tests #878

  • The SUPERCOP API (crypto_sign_*) is a compatibility layer intended for SUPERCOP benchmarking.
    Previously, the tests defined a series of SUPERCOP-style names for internal functions (the _internal variants), even though these tests are not part of the standard SUPERCOP API.

  • Instead of defining SUPERCOP-related macros in every test source file, this commit updates those macros to target the regular mldsa-native API rather than the SUPERCOP compatibility layer.
    As a result, the tests invoke the standard API directly while still using macros for name mapping.

Internal functions are now referenced via:

#define keypair_internal MLD_API_NAMESPACE(keypair_internal)

@willieyz willieyz force-pushed the eliminate-supercopAPI branch 8 times, most recently from da6eebe to afc1cf6 Compare January 21, 2026 06:30
@oqs-bot
Copy link
Contributor

oqs-bot commented Jan 21, 2026

CBMC Results (ML-DSA-87)

Full Results (173 proofs)
Proof Status Current Previous Change
**TOTAL** 2073s 2092s -0.9%
mld_attempt_signature_generation 178s 185s -4%
polyvecl_pointwise_acc_montgomery_c 165s 164s +1%
sign_verify_internal 141s 139s +1%
polyvec_matrix_expand 134s 137s -2%
rej_uniform_native 122s 121s +1%
poly_pointwise_montgomery_c 121s 129s -6%
polyvec_matrix_expand_serial 116s 117s -1%
mld_ct_memcmp 74s 79s -6%
mld_invntt_layer 58s 59s -2%
keccak_squeezeblocks_x4 43s 43s +0%
sign_signature_internal 43s 44s -2%
mld_ntt_layer 41s 43s -5%
polymat_permute_bitrev_to_custom 23s 24s -4%
rej_uniform 22s 20s +10%
mld_compute_t0_t1_tr_from_sk_components 20s 19s +5%
fqmul 19s 20s -5%
poly_uniform_4x 18s 16s +12%
polyeta_unpack 18s 16s +12%
rej_uniform_c 18s 17s +6%
poly_uniform_eta_4x 16s 15s +7%
poly_chknorm_c 15s 17s -12%
keccak_absorb_once_x4 13s 11s +18%
keccakf1600x4_permute_native 13s 13s +0%
polyveck_add 13s 13s +0%
poly_add 11s 12s -8%
polyt0_unpack 11s 14s -21%
mld_ntt_butterfly_block 10s 10s +0%
mld_polyvecl_permute_bitrev_to_custom_native 10s 11s -9%
mld_sample_s1_s2 10s 8s +25%
polyveck_ntt 10s 5s +100%
mld_check_pct 9s 5s +80%
polyvec_matrix_pointwise_montgomery 9s 10s -10%
polyveck_invntt_tomont 9s 9s +0%
sign_pk_from_sk 9s 8s +12%
keccakf1600_permute_native 8s 7s +14%
mld_compute_pack_z 8s 6s +33%
poly_invntt_tomont_c 8s 9s -11%
polyveck_caddq 8s 7s +14%
polyveck_decompose 8s 8s +0%
polyveck_pointwise_poly_montgomery 8s 8s +0%
polyveck_power2round 8s 10s -20%
polyveck_sub 8s 9s -11%
polyvecl_ntt 8s 7s +14%
keccakf1600_permute 7s 7s +0%
poly_uniform_gamma1_4x 7s 2s +250%
polyveck_chknorm 7s 5s +40%
polyveck_reduce 7s 6s +17%
polyvecl_chknorm 7s 5s +40%
sign 7s 7s +0%
unpack_hints 7s 5s +40%
mld_sample_s1_s2_serial 6s 8s -25%
poly_decompose_c 6s 9s -33%
polyveck_make_hint 6s 6s +0%
polyveck_use_hint 6s 6s +0%
rej_eta_c 6s 4s +50%
sign_signature_pre_hash_shake256 6s 5s +20%
unpack_sk 6s 6s +0%
keccak_absorb 5s 6s -17%
mld_prepare_domain_separation_prefix 5s 3s +67%
poly_uniform 5s 3s +67%
poly_use_hint 5s 3s +67%
polyveck_unpack_eta 5s 4s +25%
polyvecl_pointwise_acc_montgomery 5s 3s +67%
polyz_unpack_native 5s 2s +150%
shake256_release 5s 3s +67%
sign_verify 5s 4s +25%
sign_verify_pre_hash_internal 5s 4s +25%
keccakf1600x4_permute 4s 2s +100%
make_hint 4s 2s +100%
mld_ct_get_optblocker_u32 4s 4s +0%
mld_h 4s 5s -20%
pack_pk 4s 3s +33%
pack_sig_c_h 4s 2s +100%
poly_caddq 4s 3s +33%
poly_chknorm 4s 4s +0%
poly_chknorm_native 4s 5s -20%
poly_decompose 4s 1s +300%
poly_invntt_tomont 4s 3s +33%
poly_make_hint 4s 3s +33%
poly_use_hint_c 4s 3s +33%
polyt0_pack 4s 3s +33%
polyveck_pack_eta 4s 2s +100%
polyveck_pack_t0 4s 3s +33%
polyveck_shiftl 4s 6s -33%
polyvecl_uniform_gamma1 4s 5s -20%
polyvecl_uniform_gamma1_serial 4s 4s +0%
polyvecl_unpack_z 4s 2s +100%
polyw1_pack 4s 2s +100%
polyz_unpack_c 4s 7s -43%
reduce32 4s 4s +0%
rej_eta_native 4s 6s -33%
shake256 4s 3s +33%
shake256_init 4s 2s +100%
shake256x4_squeezeblocks 4s 3s +33%
sign_keypair_internal 4s 8s -50%
sign_signature 4s 5s -20%
sign_signature_extmu 4s 3s +33%
sign_signature_pre_hash_internal 4s 4s +0%
sign_verify_extmu 4s 5s -20%
caddq 3s 4s -25%
keccak_finalize 3s 5s -40%
keccak_init 3s 1s +200%
keccak_squeeze 3s 4s -25%
keccakf1600_xor_bytes 3s 3s +0%
keccakf1600_xor_bytes (big endian) 3s 2s +50%
keccakf1600x4_extract_bytes 3s 4s -25%
mld_ct_abs_i32 3s 3s +0%
mld_ct_cmask_nonzero_u32 3s 4s -25%
mld_ct_get_optblocker_i64 3s 4s -25%
mld_keccakf1600_extract_bytes 3s 2s +50%
mld_value_barrier_i64 3s 2s +50%
mld_value_barrier_u32 3s 2s +50%
montgomery_reduce 3s 3s +0%
pack_sig_z 3s 3s +0%
pack_sk 3s 2s +50%
poly_caddq_c 3s 4s -25%
poly_caddq_native 3s 3s +0%
poly_challenge 3s 6s -50%
poly_decompose_native 3s 3s +0%
poly_invntt_tomont_native 3s 4s -25%
poly_ntt 3s 2s +50%
poly_power2round 3s 3s +0%
poly_reduce 3s 5s -40%
poly_shiftl 3s 5s -40%
poly_uniform_eta 3s 6s -50%
poly_uniform_gamma1 3s 2s +50%
poly_use_hint_native 3s 4s -25%
polyeta_pack 3s 4s -25%
polyt1_unpack 3s 2s +50%
polyveck_unpack_t0 3s 4s -25%
polyvecl_pack_eta 3s 4s -25%
polyvecl_permute_bitrev_to_custom 3s 3s +0%
polyvecl_pointwise_acc_montgomery_native 3s 3s +0%
polyvecl_unpack_eta 3s 6s -50%
polyz_pack 3s 2s +50%
polyz_unpack 3s 3s +0%
power2round 3s 3s +0%
rej_eta 3s 6s -50%
shake128_absorb 3s 3s +0%
shake128_finalize 3s 1s +200%
shake128_init 3s 4s -25%
shake128_squeeze 3s 3s +0%
shake128x4_absorb_once 3s 3s +0%
shake256_finalize 3s 2s +50%
shake256x4_absorb_once 3s 3s +0%
sign_keypair 3s 3s +0%
sign_open 3s 3s +0%
sign_verify_pre_hash_shake256 3s 6s -50%
unpack_sig 3s 3s +0%
decompose 2s 2s +0%
mld_ct_cmask_nonzero_u8 2s 2s +0%
mld_ct_get_optblocker_u8 2s 2s +0%
mld_ct_sel_int32 2s 2s +0%
mld_value_barrier_u8 2s 2s +0%
ntt_native_x86_64 2s 3s -33%
poly_ntt_c 2s 2s +0%
poly_ntt_native 2s 4s -50%
poly_pointwise_montgomery_native 2s 4s -50%
poly_sub 2s 4s -50%
polyt1_pack 2s 3s -33%
shake128_release 2s 3s -33%
shake128x4_squeezeblocks 2s 2s +0%
sys_check_capability 2s 4s -50%
unpack_pk 2s 4s -50%
use_hint 2s 6s -67%
fqscale 1s 1s +0%
keccakf1600_extract_bytes (big endian) 1s 3s -67%
keccakf1600x4_xor_bytes 1s 2s -50%
mld_ct_cmask_neg_i32 1s 2s -50%
poly_pointwise_montgomery 1s 3s -67%
polyveck_pack_w1 1s 2s -50%
shake256_absorb 1s 2s -50%
shake256_squeeze 1s 2s -50%

@oqs-bot
Copy link
Contributor

oqs-bot commented Jan 21, 2026

CBMC Results (ML-DSA-44)

Full Results (173 proofs)
Proof Status Current Previous Change
**TOTAL** 1978s 1910s +3.6%
polyvecl_pointwise_acc_montgomery_c 220s 198s +11%
mld_attempt_signature_generation 212s 198s +7%
sign_verify_internal 169s 158s +7%
poly_pointwise_montgomery_c 152s 131s +16%
rej_uniform_native 134s 125s +7%
mld_ct_memcmp 88s 74s +19%
mld_invntt_layer 74s 72s +3%
keccak_squeezeblocks_x4 47s 44s +7%
mld_ntt_layer 46s 46s +0%
sign_signature_internal 31s 30s +3%
fqmul 22s 19s +16%
rej_uniform 22s 22s +0%
polyvec_matrix_expand 19s 18s +6%
poly_chknorm_c 18s 17s +6%
rej_uniform_c 18s 17s +6%
poly_add 16s 16s +0%
poly_uniform_eta_4x 16s 17s -6%
polyt0_unpack 16s 17s -6%
poly_uniform_4x 15s 14s +7%
polymat_permute_bitrev_to_custom 14s 17s -18%
mld_ntt_butterfly_block 13s 13s +0%
polyz_unpack_c 13s 12s +8%
keccak_absorb_once_x4 12s 12s +0%
keccakf1600_permute 12s 10s +20%
keccakf1600x4_permute_native 12s 13s -8%
mld_compute_t0_t1_tr_from_sk_components 11s 13s -15%
polyeta_unpack 11s 12s -8%
keccakf1600_permute_native 9s 7s +29%
mld_polyvecl_permute_bitrev_to_custom_native 9s 11s -18%
poly_invntt_tomont_c 9s 11s -18%
polyvec_matrix_pointwise_montgomery 9s 7s +29%
mld_check_pct 8s 7s +14%
polyveck_add 8s 7s +14%
polyveck_decompose 8s 8s +0%
polyveck_power2round 8s 6s +33%
poly_uniform_gamma1_4x 7s 4s +75%
polyvec_matrix_expand_serial 7s 7s +0%
polyveck_chknorm 7s 4s +75%
sign_pk_from_sk 7s 7s +0%
fqscale 6s 3s +100%
keccak_absorb 6s 7s -14%
mld_compute_pack_z 6s 7s -14%
polyveck_invntt_tomont 6s 8s -25%
polyveck_make_hint 6s 3s +100%
polyvecl_chknorm 6s 4s +50%
polyvecl_pointwise_acc_montgomery_native 6s 3s +100%
sign 6s 5s +20%
sign_verify 6s 3s +100%
mld_ct_get_optblocker_u32 5s 4s +25%
mld_sample_s1_s2_serial 5s 6s -17%
poly_make_hint 5s 5s +0%
poly_ntt_native 5s 2s +150%
poly_uniform 5s 5s +0%
polyt0_pack 5s 3s +67%
polyveck_pointwise_poly_montgomery 5s 4s +25%
polyveck_reduce 5s 5s +0%
polyvecl_ntt 5s 7s -29%
rej_eta_c 5s 5s +0%
rej_eta_native 5s 5s +0%
shake128_init 5s 1s +400%
sign_open 5s 7s -29%
sign_signature 5s 6s -17%
sign_signature_extmu 5s 2s +150%
sign_signature_pre_hash_shake256 5s 5s +0%
sign_verify_extmu 5s 6s -17%
unpack_hints 5s 4s +25%
caddq 4s 2s +100%
decompose 4s 4s +0%
keccak_squeeze 4s 4s +0%
make_hint 4s 4s +0%
mld_h 4s 5s -20%
mld_prepare_domain_separation_prefix 4s 3s +33%
poly_challenge 4s 3s +33%
poly_shiftl 4s 7s -43%
poly_uniform_eta 4s 5s -20%
poly_use_hint 4s 5s -20%
poly_use_hint_c 4s 4s +0%
polyveck_caddq 4s 6s -33%
polyveck_shiftl 4s 1s +300%
polyveck_sub 4s 4s +0%
polyvecl_uniform_gamma1 4s 4s +0%
polyvecl_uniform_gamma1_serial 4s 5s -20%
polyw1_pack 4s 3s +33%
shake128_absorb 4s 1s +300%
shake128x4_absorb_once 4s 3s +33%
shake128x4_squeezeblocks 4s 3s +33%
sign_signature_pre_hash_internal 4s 4s +0%
sign_verify_pre_hash_shake256 4s 6s -33%
sys_check_capability 4s 3s +33%
unpack_sk 4s 5s -20%
keccakf1600_xor_bytes 3s 3s +0%
keccakf1600_xor_bytes (big endian) 3s 2s +50%
keccakf1600x4_permute 3s 3s +0%
keccakf1600x4_xor_bytes 3s 2s +50%
mld_ct_abs_i32 3s 3s +0%
mld_ct_cmask_nonzero_u32 3s 5s -40%
mld_ct_cmask_nonzero_u8 3s 2s +50%
mld_ct_get_optblocker_i64 3s 3s +0%
mld_ct_get_optblocker_u8 3s 4s -25%
mld_sample_s1_s2 3s 3s +0%
mld_value_barrier_u32 3s 3s +0%
ntt_native_x86_64 3s 2s +50%
pack_sig_c_h 3s 3s +0%
pack_sk 3s 2s +50%
poly_caddq 3s 3s +0%
poly_caddq_c 3s 4s -25%
poly_caddq_native 3s 3s +0%
poly_decompose_native 3s 5s -40%
poly_invntt_tomont 3s 3s +0%
poly_invntt_tomont_native 3s 4s -25%
poly_ntt_c 3s 2s +50%
poly_power2round 3s 3s +0%
poly_reduce 3s 4s -25%
poly_use_hint_native 3s 3s +0%
polyt1_unpack 3s 3s +0%
polyveck_pack_eta 3s 4s -25%
polyveck_pack_t0 3s 6s -50%
polyveck_unpack_eta 3s 2s +50%
polyveck_use_hint 3s 5s -40%
polyvecl_permute_bitrev_to_custom 3s 4s -25%
polyvecl_pointwise_acc_montgomery 3s 3s +0%
polyvecl_unpack_z 3s 4s -25%
polyz_pack 3s 3s +0%
polyz_unpack 3s 3s +0%
polyz_unpack_native 3s 2s +50%
power2round 3s 2s +50%
shake128_squeeze 3s 2s +50%
shake256 3s 5s -40%
shake256_absorb 3s 2s +50%
shake256_init 3s 2s +50%
shake256_release 3s 5s -40%
sign_keypair 3s 6s -50%
sign_keypair_internal 3s 5s -40%
sign_verify_pre_hash_internal 3s 2s +50%
unpack_pk 3s 2s +50%
unpack_sig 3s 3s +0%
use_hint 3s 4s -25%
keccak_finalize 2s 3s -33%
keccak_init 2s 2s +0%
keccakf1600_extract_bytes (big endian) 2s 3s -33%
keccakf1600x4_extract_bytes 2s 4s -50%
mld_ct_cmask_neg_i32 2s 4s -50%
mld_ct_sel_int32 2s 2s +0%
mld_value_barrier_i64 2s 2s +0%
mld_value_barrier_u8 2s 3s -33%
pack_sig_z 2s 4s -50%
poly_chknorm 2s 3s -33%
poly_chknorm_native 2s 4s -50%
poly_decompose 2s 2s +0%
poly_decompose_c 2s 4s -50%
poly_ntt 2s 4s -50%
poly_pointwise_montgomery 2s 2s +0%
poly_pointwise_montgomery_native 2s 4s -50%
poly_sub 2s 4s -50%
poly_uniform_gamma1 2s 4s -50%
polyeta_pack 2s 7s -71%
polyt1_pack 2s 3s -33%
polyveck_ntt 2s 5s -60%
polyveck_pack_w1 2s 2s +0%
polyveck_unpack_t0 2s 3s -33%
polyvecl_pack_eta 2s 3s -33%
polyvecl_unpack_eta 2s 2s +0%
reduce32 2s 6s -67%
rej_eta 2s 2s +0%
shake128_finalize 2s 2s +0%
shake256_finalize 2s 3s -33%
shake256_squeeze 2s 3s -33%
shake256x4_absorb_once 2s 3s -33%
shake256x4_squeezeblocks 2s 4s -50%
mld_keccakf1600_extract_bytes 1s 1s +0%
montgomery_reduce 1s 2s -50%
pack_pk 1s 4s -75%
shake128_release 1s 4s -75%

@oqs-bot
Copy link
Contributor

oqs-bot commented Jan 21, 2026

CBMC Results (ML-DSA-65)

Full Results (173 proofs)
Proof Status Current Previous Change
**TOTAL** 2116s 2342s -9.6%
mld_attempt_signature_generation 236s 270s -13%
polyvecl_pointwise_acc_montgomery_c 216s 279s -23%
poly_pointwise_montgomery_c 140s 157s -11%
polyvec_matrix_expand 135s 143s -6%
rej_uniform_native 130s 140s -7%
sign_verify_internal 99s 107s -7%
mld_ct_memcmp 84s 89s -6%
mld_invntt_layer 60s 69s -13%
polyvec_matrix_expand_serial 57s 61s -7%
sign_signature_internal 48s 54s -11%
keccak_squeezeblocks_x4 44s 47s -6%
mld_ntt_layer 44s 48s -8%
polyveck_ntt 23s 27s -15%
rej_uniform 20s 23s -13%
fqmul 19s 20s -5%
polymat_permute_bitrev_to_custom 19s 18s +6%
poly_uniform_4x 17s 15s +13%
rej_uniform_c 17s 18s -6%
mld_compute_t0_t1_tr_from_sk_components 16s 17s -6%
poly_uniform_eta_4x 16s 17s -6%
poly_chknorm_c 15s 16s -6%
polyveck_decompose 15s 20s -25%
keccakf1600x4_permute_native 14s 13s +8%
polyvec_matrix_pointwise_montgomery 14s 11s +27%
polyt0_unpack 13s 12s +8%
keccak_absorb_once_x4 12s 14s -14%
mld_ntt_butterfly_block 11s 15s -27%
mld_polyvecl_permute_bitrev_to_custom_native 10s 9s +11%
polyveck_add 10s 11s -9%
polyveck_caddq 9s 6s +50%
polyveck_power2round 9s 13s -31%
polyvecl_ntt 9s 11s -18%
sign_pk_from_sk 9s 6s +50%
keccakf1600_permute_native 8s 7s +14%
poly_add 8s 8s +0%
polyveck_pointwise_poly_montgomery 8s 7s +14%
polyveck_reduce 8s 7s +14%
polyveck_sub 8s 11s -27%
sign 8s 9s -11%
unpack_hints 8s 4s +100%
keccakf1600_permute 7s 7s +0%
mld_compute_pack_z 7s 8s -12%
poly_decompose_c 7s 8s -12%
poly_invntt_tomont_c 7s 10s -30%
polyveck_invntt_tomont 7s 9s -22%
polyveck_shiftl 7s 6s +17%
keccak_absorb 6s 5s +20%
mld_check_pct 6s 8s -25%
mld_sample_s1_s2_serial 6s 7s -14%
poly_challenge 6s 6s +0%
polyeta_unpack 6s 5s +20%
polyveck_unpack_t0 6s 3s +100%
polyvecl_chknorm 6s 4s +50%
sign_signature 6s 5s +20%
sign_verify 6s 5s +20%
unpack_sk 6s 5s +20%
use_hint 6s 4s +50%
mld_sample_s1_s2 5s 5s +0%
poly_uniform 5s 5s +0%
poly_uniform_eta 5s 7s -29%
polyt1_unpack 5s 3s +67%
polyveck_make_hint 5s 7s -29%
polyveck_use_hint 5s 6s -17%
polyvecl_pack_eta 5s 4s +25%
polyvecl_uniform_gamma1_serial 5s 6s -17%
sign_keypair 5s 3s +67%
sign_signature_extmu 5s 7s -29%
sign_signature_pre_hash_shake256 5s 4s +25%
sign_verify_extmu 5s 7s -29%
sign_verify_pre_hash_internal 5s 3s +67%
fqscale 4s 2s +100%
mld_ct_cmask_neg_i32 4s 2s +100%
mld_ct_cmask_nonzero_u8 4s 3s +33%
mld_ct_get_optblocker_i64 4s 2s +100%
ntt_native_x86_64 4s 3s +33%
pack_sig_z 4s 4s +0%
pack_sk 4s 3s +33%
poly_caddq 4s 4s +0%
poly_chknorm_native 4s 4s +0%
poly_ntt_native 4s 5s -20%
poly_uniform_gamma1_4x 4s 4s +0%
poly_use_hint_c 4s 5s -20%
poly_use_hint_native 4s 4s +0%
polyeta_pack 4s 3s +33%
polyt0_pack 4s 6s -33%
polyveck_chknorm 4s 5s -20%
polyveck_pack_eta 4s 3s +33%
polyveck_pack_t0 4s 5s -20%
polyz_unpack_c 4s 5s -20%
polyz_unpack_native 4s 6s -33%
power2round 4s 2s +100%
rej_eta 4s 2s +100%
rej_eta_c 4s 4s +0%
rej_eta_native 4s 4s +0%
shake128_absorb 4s 2s +100%
sign_open 4s 6s -33%
sign_signature_pre_hash_internal 4s 5s -20%
unpack_pk 4s 2s +100%
unpack_sig 4s 4s +0%
caddq 3s 2s +50%
keccak_finalize 3s 4s -25%
keccakf1600_extract_bytes (big endian) 3s 3s +0%
keccakf1600_xor_bytes 3s 2s +50%
make_hint 3s 2s +50%
mld_ct_get_optblocker_u32 3s 3s +0%
mld_h 3s 5s -40%
mld_keccakf1600_extract_bytes 3s 2s +50%
mld_prepare_domain_separation_prefix 3s 4s -25%
mld_value_barrier_u32 3s 3s +0%
montgomery_reduce 3s 3s +0%
pack_sig_c_h 3s 4s -25%
poly_caddq_native 3s 2s +50%
poly_decompose 3s 6s -50%
poly_decompose_native 3s 2s +50%
poly_invntt_tomont 3s 4s -25%
poly_invntt_tomont_native 3s 6s -50%
poly_ntt 3s 3s +0%
poly_power2round 3s 4s -25%
poly_reduce 3s 3s +0%
poly_shiftl 3s 2s +50%
poly_sub 3s 3s +0%
poly_uniform_gamma1 3s 4s -25%
polyveck_unpack_eta 3s 3s +0%
polyvecl_pointwise_acc_montgomery_native 3s 3s +0%
polyvecl_uniform_gamma1 3s 3s +0%
polyvecl_unpack_eta 3s 2s +50%
polyvecl_unpack_z 3s 4s -25%
polyw1_pack 3s 6s -50%
polyz_unpack 3s 1s +200%
reduce32 3s 2s +50%
shake128_finalize 3s 2s +50%
shake128_squeeze 3s 3s +0%
shake128x4_absorb_once 3s 2s +50%
shake128x4_squeezeblocks 3s 3s +0%
shake256_absorb 3s 3s +0%
shake256_release 3s 6s -50%
shake256x4_squeezeblocks 3s 3s +0%
sign_keypair_internal 3s 4s -25%
sign_verify_pre_hash_shake256 3s 5s -40%
decompose 2s 5s -60%
keccak_squeeze 2s 4s -50%
keccakf1600_xor_bytes (big endian) 2s 2s +0%
keccakf1600x4_extract_bytes 2s 2s +0%
keccakf1600x4_xor_bytes 2s 2s +0%
mld_ct_abs_i32 2s 4s -50%
mld_ct_cmask_nonzero_u32 2s 4s -50%
mld_ct_get_optblocker_u8 2s 3s -33%
mld_ct_sel_int32 2s 2s +0%
mld_value_barrier_i64 2s 1s +100%
mld_value_barrier_u8 2s 3s -33%
poly_caddq_c 2s 3s -33%
poly_chknorm 2s 4s -50%
poly_make_hint 2s 6s -67%
poly_ntt_c 2s 4s -50%
poly_pointwise_montgomery 2s 2s +0%
poly_pointwise_montgomery_native 2s 3s -33%
poly_use_hint 2s 4s -50%
polyt1_pack 2s 2s +0%
polyveck_pack_w1 2s 2s +0%
polyvecl_permute_bitrev_to_custom 2s 2s +0%
polyvecl_pointwise_acc_montgomery 2s 2s +0%
polyz_pack 2s 4s -50%
shake128_release 2s 3s -33%
shake256_init 2s 2s +0%
shake256x4_absorb_once 2s 1s +100%
sys_check_capability 2s 3s -33%
keccak_init 1s 3s -67%
keccakf1600x4_permute 1s 3s -67%
pack_pk 1s 3s -67%
shake128_init 1s 3s -67%
shake256 1s 3s -67%
shake256_finalize 1s 4s -75%
shake256_squeeze 1s 3s -67%

@willieyz willieyz marked this pull request as ready for review January 21, 2026 07:10
@willieyz willieyz requested a review from a team as a code owner January 21, 2026 07:10
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willieyz.

You forgot to modify test_stack.c and test_rng_fail.c. In the files you changes you forgot a lot of functions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still using the SUPERCOP API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still using the SUPERCOP API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still using the SUPERCOP API

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the SUPERCOP API in 25 places....

@willieyz willieyz force-pushed the eliminate-supercopAPI branch 4 times, most recently from 7880ef1 to b4779ed Compare January 29, 2026 05:51
The SUPERCOP API (crypto_sign_*) is a compatibility layer intended for
SUPERCOP benchmarking.
Previously, the tests defined a series of SUPERCOP-style names for
internal functions (the _internal variants), even though these tests
are not part of the standard SUPERCOP API.
Instead of defining SUPERCOP-related macros in every test source file,
this commit updates all test files to include sign.h instead of directly
including mldsa_native.h, allowing them to directly use the
mld_sign_* functions defined in sign.h.
It also adds MLD_CHECK_APIS in each test source files, ensuring that
mldsa_native.h is still included during compilation.

Signed-off-by: willieyz <willie.zhao@chelpis.com>
@willieyz willieyz force-pushed the eliminate-supercopAPI branch from b4779ed to 50b94dd Compare January 29, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eliminate SUPERCOP API from tests

4 participants