-
Notifications
You must be signed in to change notification settings - Fork 35
Eliminate SUPERCOP API from tests #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
da6eebe to
afc1cf6
Compare
CBMC Results (ML-DSA-87)Full Results (173 proofs)
|
CBMC Results (ML-DSA-44)Full Results (173 proofs)
|
CBMC Results (ML-DSA-65)Full Results (173 proofs)
|
mkannwischer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @willieyz.
You forgot to modify test_stack.c and test_rng_fail.c. In the files you changes you forgot a lot of functions.
test/acvp/acvp_mldsa.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still using the SUPERCOP API.
test/bench/bench_mldsa.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still using the SUPERCOP API.
test/bench/bench_mldsa.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.
test/src/gen_KAT.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still using the SUPERCOP API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the SUPERCOP API in 25 places....
7880ef1 to
b4779ed
Compare
The SUPERCOP API (crypto_sign_*) is a compatibility layer intended for SUPERCOP benchmarking. Previously, the tests defined a series of SUPERCOP-style names for internal functions (the _internal variants), even though these tests are not part of the standard SUPERCOP API. Instead of defining SUPERCOP-related macros in every test source file, this commit updates all test files to include sign.h instead of directly including mldsa_native.h, allowing them to directly use the mld_sign_* functions defined in sign.h. It also adds MLD_CHECK_APIS in each test source files, ensuring that mldsa_native.h is still included during compilation. Signed-off-by: willieyz <willie.zhao@chelpis.com>
b4779ed to
50b94dd
Compare
Resolves: Eliminate SUPERCOP API from tests #878
The SUPERCOP API (crypto_sign_*) is a compatibility layer intended for SUPERCOP benchmarking.
Previously, the tests defined a series of SUPERCOP-style names for internal functions (the _internal variants), even though these tests are not part of the standard SUPERCOP API.
Instead of defining SUPERCOP-related macros in every test source file, this commit updates those macros to target the regular mldsa-native API rather than the SUPERCOP compatibility layer.
As a result, the tests invoke the standard API directly while still using macros for name mapping.
Internal functions are now referenced via: