Adding build script for lingua-rs by vijay-vin · Pull Request #8181 · ppc64le/build-scripts

vijay-vin · 2026-04-27T19:06:23Z

Checklist

[ x] Have you checked and followed all the points mention in the CONTRIBUTING.MD
[ x] Have you validated script on UBI 9 container
[ x] Did you run the script(s) on fresh container with set -e option enabled and observe success ?
[ x] Did you have Legal approvals for patch files ?

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

vijay-vin · 2026-04-27T22:04:57Z

Here are last few lines from running the build script showing it as success along with test results.

echo 'Running upstream Python tests with pytest...'
Running upstream Python tests with pytest...
pytest tests/python
=============================================================== test session starts ===============================================================
platform linux -- Python 3.12.12, pytest-9.0.3, pluggy-1.6.0
rootdir: /build/lingua-rs
configfile: pyproject.toml
collected 74 items

tests/python/test_builder.py ........... [ 14%]
tests/python/test_confidencevalue.py ... [ 18%]
tests/python/test_detectionresult.py ... [ 22%]
tests/python/test_detector.py .................... [ 50%]
tests/python/test_isocode.py ............ [ 66%]
tests/python/test_language.py .............. [ 85%]
tests/python/test_writer.py ........... [100%]

=============================================================== 74 passed in 0.34s ================================================================

'[' 0 -ne 0 ']'
echo ''
echo 'SUCCESS: lingua-language-detector 2.2.0 built and validated'
SUCCESS: lingua-language-detector 2.2.0 built and validated
echo ''

[root@onprem133723021 lingua-ubi-build]#

adarshagrawal38 · 2026-04-28T05:44:01Z

+set -e
+
+# Variables
+PKG_NAME="lingua-language-detector"


Suggested change

PKG_NAME="lingua-language-detector"

PACKAGE_NAME="lingua-language-detector"

adarshagrawal38 · 2026-04-28T05:44:54Z

+PKG_NAME="lingua-language-detector"
+PKG_VERSION="2.2.0"
+PKG_ORG="pemistahl"
+PKG_REPO="lingua-rs"


Lets keep the variable name as per: https://github.com/ppc64le/build-scripts/blob/master/templates/build_script_python.sh#L23

adarshagrawal38 · 2026-04-28T05:46:51Z

+ln -sf /usr/bin/python3.12 /usr/bin/python3
+ln -sf /usr/bin/pip-3.12 /usr/bin/pip3
+ln -sf /usr/bin/python3.12 /usr/bin/python
+ln -sf /usr/bin/pip-3.12 /usr/bin/pip


Normalize Python commands block not required, python version will be managed GHA.

adarshagrawal38 · 2026-04-28T05:49:19Z

+# ------------------------------------------------------------------------------
+
+sed -i \
+  "s/^version = .*/version = \"${PKG_VERSION}+${IBM_SUFFIX}\"/" \


We can skip this line, as we don't apply suffix in front of version.

adarshagrawal38 · 2026-04-28T05:51:07Z

+
+echo "Running upstream Python tests with pytest..."
+pytest tests/python
+if [ $? -ne 0 ]; then


Take a look here, this is how we execute test cases

Done. Modified the script according to the template.

adarshagrawal38 · 2026-04-28T05:52:37Z

+fi
+
+echo ""
+echo "SUCCESS: ${PKG_NAME} ${PKG_VERSION} built and validated"


Generally we don't have this kind of messages at the end.

Done. Removed the echo statement.

adarshagrawal38 · 2026-04-28T06:39:20Z

+{
+  "maintainer": "vijay-vinnakota",
+  "package_name": "lingua-language-detector",
+  "github_url": "https://github.com/pemistahl/lingua-rs",


Where we not able to build pkg from lingua-py?

From version 2 on, the repo is lingua-rs

adarshagrawal38 · 2026-04-29T08:05:45Z

+# ------------------------------------------------------------------------------
+echo "Building wheel using maturin..."
+
+maturin build --release --strip


You can build the pkg using pip as well
reference here

While pip can invoke the build, lingua-rs is a PyO3‑based Rust extension package and the build configuration explicitly uses maturin as build backend as defined in repo's pyproject.toml file.

Please ignore my above comment. I misunderstood your comment.
I have now changed the build command to use pip per the template.

adarshagrawal38 · 2026-04-29T08:06:04Z

+
+WHEEL_FILE="$(ls target/wheels/${PKG_NAME//-/_}-*.whl | head -n 1)"
+
+if [[ ! -f "${WHEEL_FILE}" ]]; then


No need to locate wheel

The wheel check is intentional—it resolves and validates the exact wheel filename produced by maturin before installation. Since the install step depends on this variable, the check helps fail early with clearer diagnostics. Essentially, treating the generated wheel filename validated before input for the installation step.

Please ignore my above comment. I have removed all those lines now as they are not needed in my new updated script where i am using pip and not maturin.

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

ghatwala · 2026-04-30T13:43:55Z

@cdeepali can you please help review this PR once as this is for a new package addition ? cc : @prachikurade1

adarshagrawal38 · 2026-05-05T13:15:18Z

@yussufsh PTAL

adarshagrawal38 · 2026-05-05T13:16:55Z

@cdeepali can you please review the PR, as we want to merge PR

cdeepali · 2026-05-06T13:43:45Z

+# Install dependencies (UBI 9.6 + RPM Python 3.12)
+# ------------------------------------------------------------------------------
+
+dnf install -y \


Pls put this on a single line.

I intentionally kept them on separate lines for readability and easier maintenance. It is quite a big list and may span across the screen on one line. Please let me know if you'd still prefer it flattened into one line.

I Agree that it should be a multiline command for readability.

But for specific handling that is done in wrapper script in our workflow - we expect the it to be on a single line or atleast the python specific command should be together on first line, the others can be on separate lines.
Pls refer to this template for more details - https://ibm.ent.box.com/file/2211466225461?s=klya622gmi0ghvx2os8k0br8861qqwpi.

Got it. Will make the changes.
Also, the above ibm box link says, "folder link has been removed or is unavailable to you".

cdeepali · 2026-05-06T14:48:40Z

+# Package        : lingua-language-detector
+# Version        : 2.2.0
+# Source repo    : https://github.com/pemistahl/lingua-rs
+# Tested on      : UBI 9.6


Suggested change

# Tested on : UBI 9.6

# Tested on : UBI:9.6

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

cdeepali · 2026-05-08T04:29:59Z

@cdeepali test notification

adarshagrawal38 · 2026-05-11T05:49:45Z

+set -e
+
+# Variables
+PACKAGE_NAME="lingua-language-detector"


Suggested change

PACKAGE_NAME="lingua-language-detector"

PACKAGE_NAME="lingua-rs"

As we discussed in the call, I kept the name as is, but renamed the folder name. The package name will match as what is called in the upstream.

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

adarshagrawal38 · 2026-05-12T05:04:54Z

+  "maintainer": "vijay-vinnakota",
+  "package_name": "lingua-language-detector",
+  "github_url": "https://github.com/pemistahl/lingua-rs",
+  "version": "2.2.0",


There is no 2.2.0 in the release tag yet
1.8.0 is the latest

adarshagrawal38 · 2026-05-12T05:08:25Z

+# Clone source (lingua-rs is Git-only;)
+# ------------------------------------------------------------------------------
+
+git clone "${PACKAGE_URL}"


You have missed to take git checkout on the PACKAGE_VERSION

please follow the template here, you can skip line 65 - 84 which is for extracting tar file

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

Adding build script for lingua-rs

fb64b2f

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

adarshagrawal38 reviewed Apr 28, 2026

View reviewed changes

adarshagrawal38 reviewed Apr 29, 2026

View reviewed changes

vijay-vin added 3 commits April 29, 2026 09:59

changes per review comments

5443a23

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

Fixed variable name

50effbd

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

Replacing maturin with pip

ba7bf01

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

ghatwala requested a review from cdeepali April 30, 2026 13:43

cdeepali reviewed May 6, 2026

View reviewed changes

flattned install package list

4b3b78e

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

cdeepali approved these changes May 8, 2026

View reviewed changes

adarshagrawal38 reviewed May 11, 2026

View reviewed changes

vijay-vin added 2 commits May 11, 2026 11:13

renamed the directory to match package name

dd13d33

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

fixed package_dir

2af0e20

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

adarshagrawal38 reviewed May 12, 2026

View reviewed changes

vijay-vin added 2 commits May 12, 2026 13:23

using python3.12 instead of pip3.12

92c13f2

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

fixing version number to match tag version

17f3fa4

Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>

	PKG_NAME="lingua-language-detector"
	PACKAGE_NAME="lingua-language-detector"


		WHEEL_FILE="$(ls target/wheels/${PKG_NAME//-/_}-*.whl \| head -n 1)"

		if [[ ! -f "${WHEEL_FILE}" ]]; then

	PACKAGE_NAME="lingua-language-detector"
	PACKAGE_NAME="lingua-rs"

Conversation

vijay-vin commented Apr 27, 2026

Checklist

Uh oh!

vijay-vin commented Apr 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adarshagrawal38 Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghatwala commented Apr 30, 2026

Uh oh!

adarshagrawal38 commented May 5, 2026

Uh oh!

adarshagrawal38 commented May 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cdeepali commented May 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adarshagrawal38 Apr 28, 2026 •

edited

Loading