Repository navigation
Fix IME positioning with hidden terminal cursors - #431
Merged
Merged
Conversation
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminal repaints left xterm's logical cursor at the bottom whenever Herdr hid the cursor, displacing IME composition from the application's input field. Restore valid cursor coordinates regardless of visibility, while preserving cursor visibility and viewport clipping. Add serializer and real xterm regression coverage for repeated repaints and visibility changes.
Fixes #429.
Validation:
bun test server/src/bridge/frame-to-ansi.test.ts web/src/endpointFrame.test.ts web/src/terminalEndpointPresentation.test.ts server/src/bridge/endpoint-terminal-session.test.ts server/src/bridge/terminal-bridge.test.ts.bun run typecheckpassed, including the frontend production build and asset checks.bun run lintandbun run typecheck:bun.(7,26); the old serializer left it at(100,29), while this patch restored(7,26)and kept it hidden. No agent prompt was submitted.Native macOS Pinyin composition and candidate-window placement remain unverified in a browser because browser control was unavailable. Kimi 2.2.0 stopped at the temporary folder's trust prompt, so its input field was not tested. The original issue's Kimi 2.1.1 / Herdr 0.9.3 environment has not been reproduced.