Repository navigation
Reject Ranger worktree creation on Windows SSH hosts - #403
Merged
Merged
Conversation
Ranger's create_worktree action called the Unix-only Git root and worktree hook helpers directly, bypassing the Windows guard that the ordinary RPC path applies. It now fails before any resource helper or Herdr call runs; native actions such as create_tab are unchanged. Fixes #402 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019MY2e8XVKiGDxDV3mXeV7f
Address review findings on the Windows worktree fix: - The connection runtime now makes its Unix-only file, Git, agent-history, and worktree-hook helpers throw on Windows hosts, so any caller that skips its own check still cannot run Unix shell commands there. createWorkspaceWorktree also checks up front. - Replace the per-caller messages with a shared assertUnixHost helper and UnsupportedPlatformError. Ranger tool wrappers surface that error to the model verbatim instead of the generic failure, and the worktree check now runs after the lease and abort checks. - workspace_status reports remote_platform "windows", and the history, diff, and worktree tool descriptions say they are unavailable there. - Document the contract in ARCHITECTURE.md and link to it from DEPLOYMENT.md with clearer wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019MY2e8XVKiGDxDV3mXeV7f
Owner
Author
|
@codex review The PR has two commits. The PR description only covers the first one.
Please check in particular whether any code path that can run on Windows still calls the guarded helpers. Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ranger's create_worktree action called the Unix-only Git root and
worktree hook helpers directly, bypassing the Windows guard that the
ordinary RPC path applies. It now fails before any resource helper or
Herdr call runs; native actions such as create_tab are unchanged.
Fixes #402
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_019MY2e8XVKiGDxDV3mXeV7f