Conversation
npm global installs now ship JS PATH shims (native binaries go to vendor/), cargo install forgemax builds forgemax-worker, and worker discovery finds .forgemax-worker.exe on Windows. SECURITY.md names GitHub PVR and a maintainer email. Optional [observability] serves /health and /metrics and supports JSON logs without changing dispatcher traits or existing TOML. Co-authored-by: postrv <postrv@users.noreply.github.com>
Remove accidental #[test] duplication on new unit tests. Replace a no-arg format! in forge-test-server so clippy -D warnings stays clean on current stable. Co-authored-by: postrv <postrv@users.noreply.github.com>
Gate observability metrics types so --no-default-features compiles. Bump anyhow to 1.0.104 (RUSTSEC-2026-0190) and rmcp to 1.8.0 (RUSTSEC-2026-0189) within existing semver ranges. Co-authored-by: postrv <postrv@users.noreply.github.com>
Co-authored-by: postrv <postrv@users.noreply.github.com>
Register IPC waiters in a mutex map before writing the request so a fast parent StashResult cannot arrive before the oneshot exists. The previous async-channel registration dropped the response and left child_process_stash_put_get_through_ipc in the 300s sandbox timeout. Co-authored-by: postrv <postrv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining Ubuntu CI failures on this branch (
Test (ubuntu-latest)andMinimal build).child_process_stash_put_get_through_ipcwas not a missing#[serial]problem. The four tests that looked concurrent were waiting on the serial lock while the stash test held it for the full 300s sandbox timeout.Cause: the worker registered IPC waiters on an async channel. A fast parent
StashResult(same race for tool/resource results) could be read before the waiter was inserted, so the oneshot never fired.Fix: insert waiters into a mutex map before the request is written. Added
child_process_stash_many_roundtrips_through_ipc(32 put/get pairs) to keep the race from coming back.Also in this PR (unchanged intent):
forgemax-workeroncargo install/health,/ready,/metrics) and JSON logsDoes not change dispatcher trait signatures or
DispatchErrorvariants. Existingforge.tomlstill parses. Homebrew tappostrv/homebrew-forgemaxis a separate repo and stays on 0.5.0 until that tap is updated.