docs: add command-v example pair - #11
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new standard example demonstrating why command -v should be preferred over which for checking command availability, updating the README table accordingly. The feedback suggests renaming the example files and README entry to use sequential numbering (changing 12 to 11 as 11 was skipped) and removing the redundant stderr redirection (2>&1) from the command -v check in the good example.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
6f48fd1 to
910775c
Compare
|
Thank you for your contribution. I will review it carefully and come back with my feedback soon. |
posidoni
left a comment
There was a problem hiding this comment.
Thanks for the clean contribution! This closes #8 exactly per the contract in CONTRIBUTING.md — the command -v vs which example pair is correct, safe, and both gemini-code-assist nits (file renumbering, redundant 2>&1) are already addressed. CI is green on all required checks. Merging now.
|
Merged — thank you for the contribution, @pollychen-lab! This is exactly the kind of clean, well-tested example the project needs. Appreciate you taking the time. |
Summary
command -vvswhichCloses #8.
Validation
git diff --checkshellcheck --severity=warning examples/standards/11-command-v-not-which.good.shinalpine:3.20containershellcheck --severity=style --format=gcc examples/standards/11-command-v-not-which.bad.shinalpine:3.20container: reportsSC2230shfmt -d examples/standards/11-command-v-not-which.good.sh examples/standards/11-command-v-not-which.bad.shinalpine:3.20container./tools/check-bad-examples.shinalpine:3.20containerbats tests/examples.batsinalpine:3.20container