Feature/ReadonlyFormField and ReadonlyFormFieldWrapper refactoring#222
Open
freesbi wants to merge 9 commits intoporscheinformatik:masterfrom
Open
Feature/ReadonlyFormField and ReadonlyFormFieldWrapper refactoring#222freesbi wants to merge 9 commits intoporscheinformatik:masterfrom
freesbi wants to merge 9 commits intoporscheinformatik:masterfrom
Conversation
added 9 commits
March 28, 2025 16:33
…rapper, remove content observer which cause performance issues
stefan-isakovic
approved these changes
Apr 11, 2025
| @Input('unitPosition') unitPosition: 'right' | 'left' = 'left'; | ||
| @Input('errorMessage') errorMessage: string | null = null; | ||
| @Input() id: string; | ||
| @Input() id!: string; |
There was a problem hiding this comment.
Here and everywhere else: I think we should use
Suggested change
| @Input() id!: string; | |
| @Input({ required: true }) id: string; |
instead :)
| this.doRendering(); | ||
| ngOnChanges(_: SimpleChanges): void { | ||
| if (this.initialized) { | ||
| this.syncView(); |
| export class ReadOnlyFormFieldComponent implements OnChanges, AfterViewInit { | ||
| @Input() useProjectedContent: boolean = false; | ||
| @Input() value?: any; | ||
| @Input() label!: string; |
There was a problem hiding this comment.
This & other files, same as above:
Suggested change
| @Input() label!: string; | |
| @Input({ required: true }) label: string; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored ReadonlyFormField and ReadonlyFormFieldWrapper, because of performance issues.
There was several performance issues with both of the components.
Alert icons styles allignment
Which Component is affected or generated?