Clear leftover begin() onclose handler after the transaction settles - #1201
Open
gepotumu wants to merge 1 commit into
Open
Clear leftover begin() onclose handler after the transaction settles#1201gepotumu wants to merge 1 commit into
gepotumu wants to merge 1 commit into
Conversation
sql.begin() races the transaction against connection.onclose = reject, but never removes that handler. After a successful commit the pooled connection can later close (idle timeout, sql.end, server-side recycle) and reject(undefined), which surfaces as an unhandledRejection. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sql.begin()races the transaction againstconnection.onclose = rejectso a disconnect during the transaction can fail thebegin()promise.sql.end(), server-side recycle) still callsreject. The raced promise is already settled, so this becomesunhandledRejection— oftenundefined.connection.oncloseinfinally. Add a regression test that commits a transaction, then closes the pool and asserts no leftover rejection.Test plan
node tests/index.js(needs the usualpostgres_js_testsetup)await sql.begin(...), close the connection viasql.end({ timeout: 0 })or idle timeout and confirm nounhandledRejectionMade with Cursor