Repository navigation
feat: write a v3 table's multi-step commits together - #151
Merged
Merged
Conversation
`ChainedAppendAction` wrote a v3 table's steps one by one — four sequential round trips to object storage each — since the fork's staged snapshots couldn't record v3 row ranges. polynya-dev/iceberg-rust#8 lets them: each step's rows take the row ids after the last's. A v3 table's first such commit since an upgrade with data still goes one by one: its first list gives the files from before the upgrade row ids too, a range a staged step can't record. Pins it: the catalog test of a chain's round trips on v3 (and its row ids), and DST cases of a several-step commit on v3 and right after an upgrade, on the sim and iceberg-rust. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
polynya-dev/iceberg-rust#8 merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A commit of several steps writes its snapshots together on v3 tables now, as it already did on v2. That covers a materializer catching up, or a transaction too big for one step.
Until now
ChainedAppendActionfell back to committing a v3 table's steps one at a time: about four sequential object-store round trips per snapshot, versus two parallel rounds for the whole chain. The fork's staged snapshots couldn't record v3 row ranges. polynya-dev/iceberg-rust#8 adds that: each staged snapshot's rows take the row ids after the last's, and its data manifest keeps its ids when a later list carries it.One case still commits one by one: a v3 table's first multi-step commit after an upgrade with data in it. That commit's first list gives the pre-upgrade files row ids too, a range a staged step can't record.
ChainedAppendActionchecks the parent's manifests for a data manifest without ids first.