Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1bd6d72030
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !valid || len(msg.ViewCounts) == 2 { | ||
| badViews = true | ||
| } | ||
| if !badViews { | ||
| msg.ViewCounts = append(msg.ViewCounts, types.NewsletterViewCount{Type: definition, Count: count}) |
There was a problem hiding this comment.
When a message contains exactly two views_count nodes with the same definition (both untyped or both type="views") and conflicting counts, this check accepts both and sets ViewsCountPresent to true. The new observation API therefore exposes two contradictory counts for one definition as valid, despite its documented guarantee that ambiguous observations are omitted. Track the definitions already seen and invalidate the view observation on a duplicate, while continuing to accept the untyped and views pair in either order.
Useful? React with 👍 / 👎.
Current source readiness, 2026-10-30
Not review-ready yet at
1bd6d720307722740fee39ba2fd8cdbd8cb8a4ce. Company attribution source/template changes are prepared locally, preserving personal/upstream attribution, years and license terms. Actual MEX producer execution and focused qualification remain unrun; incomplete generated-source work has not been pushed. The one bounded standard producer/focused-check claim expired with exit75 before CLAIMED; no command started. Old-head CI and prior publication receipts are historical. No independent approval, package publication, deployment or legal/activation acceptance is inferred. Release owns merges; H53 independent approval remains a merge gate. No new review or watch was requested.Actual
git rebase --rebase-merges --ontocompleted against current target7c0cd0e3c1739dbc7292a822bc5dd9e6c2ce71a1. Head1bd6d720307722740fee39ba2fd8cdbd8cb8a4ce→1bd6d720307722740fee39ba2fd8cdbd8cb8a4ceis unchanged. Current target is an ancestor; full treecc4c252323c20a768973ebff0bea18fbe40ac554is unchanged. Old/new parent mapping is exact; no cosmetic commit or source push. Existing combined-head CI admission/deployment holds remain where applicable. Recovery refrefs/heads/backup/parity-rebase-20261028/pr-54-1bd6d720is verified remotely at1bd6d720307722740fee39ba2fd8cdbd8cb8a4ce. Release alone owns source merge slots. Legal/independent-review, package/activation/publication and effective deployment-pause gates remain; staging DEFERRED. POL35 and Business H55/migration20 remain separate.Preserve reported newsletter counter presence and both view definitions without choosing an account gate. Keep existing scalar APIs; missing/malformed counters stay distinct from reported zeros and an explicit empty reaction map. Over-limit or ambiguous observations are omitted as a whole rather than truncated.
Decode milestone positions from quoted or numeric decimal integers without floating-point conversion, while retaining the existing quoted JSON output. Position-only live updates keep their absent original ID. No protobuf/version change, message-body export, active request or flag change.
Stacked on #53; retarget to main after its separately authorized merge and requalify exact downstream pins. Tracks POL-81. Backend, six SDKs, CLI and docs follow in the same confirmed cycle.
Verification: the numeric milestone and reported-zero regressions failed before their fixes. Focused native MEX/counter tests, full Go 1.26 tests, full Go 1.27 race suite, MEX generation check, WASM compile and full pre-commit passed. Includes missing/zero/empty, multiple view definitions, malformed/overflow IDs and reaction-limit fixtures. No live account, phone, browser, deployment or package-availability claim.
Confirmed scope checkpoint, registration #511. Owner: Codex/T3/OpenAI, gpt-6.1-sol/xhigh; one writer, no implementation subagents or automated reviews requested. Partial manual provenance; complete recorder capture unavailable. No UI changed. This is a Polymorfa fork change, not an upstream submission.
Keep draft through consumer qualification and required checks/review. No protected merge, tag/release, publication, deployment or activation. Roll back the producer and consumer pin together, preserving stored data and current retirement/authority guards.
Need help on this PR? Tag
@codesmith-botwith what you need.