Repository navigation
Conversation
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 11 minutes. View limit details
|
purpshell
changed the title
sdks#345 is now 94095b4c and polymorfa#562 is 3766dc9a (spec 40daa415). Still unpublished; the registry SDK pin and release hold are unchanged.
a4280c5 to
3fcec37
Compare
sdks#345 was reconciled with SDK main 4357c53b and rebound its doc snippets; its head is now 77dc45bd. The installed registry SDK pin and release hold are unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82943f61eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| base64: z | ||
| .string() | ||
| .min(1) | ||
| .regex(/^(?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==|[A-Za-z0-9+/]{3}=)?$/) |
There was a problem hiding this comment.
For carousel cards containing several megabytes of inline media, this regex throws RangeError: Maximum call stack size exceeded instead of accepting valid base64. On the available Node 24 runtime, evaluating this exact expression against 'A'.repeat(5_000_000) reproduces the failure; a carousel containing that source and a second small card remains below the documented 10 MiB JSON-input cap. Since safeParse does not catch exceptions thrown by regex evaluation, these otherwise valid sends fail before transport. Use a stack-safe character/padding validation and length check, and add a regression covering a multi-megabyte source.
Useful? React with 👍 / 👎.
Add typed carousel sends, image/video/document button headers and mixed reply/URL/call controls. Validate card media, control bounds and stable reply IDs before one HTTP send. Reject unsupported card footers; the outer carousel retains its footer.
The source contract still pins SDK #345 at
77dc45bd8a5ae592b0f76563d303738b2c0c3426with publication disabled. The installed registry dependency is unchanged and lacks the required exports, so clean builds remain blocked. No raw-transport workaround or invented package version.Fresh footer regression added; it has not run because the serialized qualification request expired before starting. Prior-head Node/Windows CI failed in the known SDK dependency build gate; successor natural CI must qualify this head. Smallest next action: supply an authorized matching published SDK version and update the registry dependency/lock, then run clean qualification. Package publication itself is outside this task.
Draft. No API, Admin, billing/Usage, tracking, onboarding or feature-availability change. Merge and release remain with Release.