Repository navigation
Conversation
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 11 minutes. View limit details
|
testing phone get, send and unlink call the Testing phone routes from polymorfa/polymorfa#526 through the SDK methods in polymorfa/sdks#341. The SDK pin moves to the prerelease that contains them before merge.
7a65c0f to
e3077d7
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Rebase the Test-number phone commands onto actual CLI main
a9a19cd68eecf7f33eae495665c1f389b6906a5e, incorporating merged Zod #91:^4.6.6, locked4.6.7.Head:
7a65c0f700aeba5178bb4dbb0b9f97e7fb42339d→e3077d720905239ed049916c09daa6eab8266280. Tree:2057613bb8316fc947f63f104dc90b7b359b13e6. The new sole parent is current main. One atomic push used an explicit expected-old-head force lease; old history has backup refs and a verified Git bundle.Keep draft. The unchanged SDK pin,
0.1.0-dev.20261004024706, lacksTestingResource.getPhone,sendPhoneMessageandunlinkPhoneDevice. This source is not functionally qualified or ready to merge.Previous comparison base:
43e55a4940d1046e23cd1763f3345c27ebbe85d3. New base:a9a19cd68eecf7f33eae495665c1f389b6906a5e.Impact
Impact table
No impact table
Verification
Published dependency inventory, 2026-10-28: All 54 versions in the official npm registry snapshot were inspected without installation or execution. Every archive passed its registry SHA512 integrity check. None exposes
getPhone,sendPhoneMessageorunlinkPhoneDevicein its JavaScript or declarations, and none containsrelease-contract.json. All 54 have the same TestingResource implementation/declaration hashes as the current pin. A final conditional registry read at 05:16:52Z returned HTTP 304. There is no already-published accepted SDK #341 artifact to substitute.SDK #341 merge
4e6f638d15870a7c1318229255cf400270413f2cis contained in SDK main3b222dcad98b25da4b5b2e0c0b367988eca95e99, where all three source methods exist. The concrete publication dependency is SDK publisher run 40466460971, job 122062940434: its acceptance-authority App action failed because theclient-idinput was empty, before acceptance, package build or publication. No secret values were inspected. The existing publisher must obtain its configured authority input, validate matching API/feature acceptance and produce an actual containing package with a matching release receipt. Source presence alone does not qualify a pin update.The private
campaigns-sdk-dependency-proof-20261028/DEPENDENCY-DISPOSITION.mdpacket records exact registry/archive/source hashes, the Testing contract supplement versus global contract pin, fixture limits and six-part impact. No SDK pin, source or package was changed for this assessment.At the new head, Node 24.15 and serial workers under the standard shared lease:
OCLIF_TEST_ROOTselects the exact-source validation copy. Original installed Vitest resolution is verified; no install or version fallback. Earlier incomplete-copy collection failures remain retained.Hosted Node 22.23.3 Verify job 122631402394 failed on this head.
npm cireached the package'sprepare→ build hook, then exited 2 on the same three missing SDK methods (plus the consequent untyped device callback). The actual checkout was mergede0faaacb83c00d5637b47a6bf319f3977ebf12d, whose tree exactly equals this head's tree.npm run verifyand release-evidence tests were skipped; no new-head audit or runtime-suite pass is claimed. This confirms the source/package dependency blocker rather than an npm download or runner-capacity failure. Old CI/reviews do not qualify this head; installed-package, staging and provider acceptance remain open. No rerun, audit suppression or SDK pin workaround.Six-part assessment, exact commands, exits, hashes, preserved failures and old/new mappings: owner packet
owned-pr-rebases-20261028/HANDOFF.md, SHA256427c6c93f8ac61545352929dcafb790a0bccf15a257c2302c1336abb80ec4f09; receipt SHA2566f173f05fadf7e45ed6ef0a9610c30e62dd0640db9c0440379dd032fffae158f. Logs remain privately retained.Session provenance and UI evidence
Existing ordinary Campaigns owner thread
646a0c0a-e900-4d0f-9a25-0b8834d7d4e6, user-selected Codex gpt-6.1-sol/xhigh; no child or second writer. Historical authored-task checkpoint remains at monorepo6d3c2a680f03ab765c2dab80d1cb2ef80dfb9ee0,internal/agent-sessions/sessions/purpshell-t3-claude/test-number-parity-merge/218b8b1df35ee9ecb995ac3a303464f7bc2df99e7376a173c2bac251759a3851.md(registration #518). Current visible command receipts are retained; complete transcript capture is not claimed. CLI/synthetic fixtures only; no GUI change.Rollout and rollback
Release alone selects a merge slot. Preserve the SDK pin until an exact accepted package and matching receipt are supplied, then qualify that separate change. Nightly/stable publication and environment gates remain; staging is deferred. No registry/tag, merge, reviewer request or CI rerun.
Old heads are recoverable from backup refs/bundles. No automatic history restoration or runtime rollback is performed.