Conversation
There was a problem hiding this comment.
Pull request overview
Updates the aiosocketpool package to align with newer asyncio loop APIs and raises the declared minimum supported Python version, along with README example tweaks.
Changes:
- Raise
requires-pythonto>=3.11. - Replace deprecated/legacy
asyncio.get_event_loop()usage withasyncio.get_running_loop()in async socket operations and reaper startup. - Update README examples to use
asyncio.create_task()/await asyncio.gather()and add guidance for running examples in an asyncio shell.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Raises minimum Python version to 3.11 in project metadata. |
| aiosocketpool/init.py | Updates loop acquisition patterns and makes the reaper startup tolerant of being constructed before a loop is running. |
| README.md | Adjusts examples for modern asyncio usage and adds a note about running in an asyncio-enabled shell. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
24a8094 to
f72ef3f
Compare
64dcb9e to
b67d627
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull request overview
Updates the
aiosocketpoolpackage to align with newer asyncio loop APIs and raises the declared minimum supported Python version, along with README example tweaks.Changes:
requires-pythonto>=3.11.asyncio.get_event_loop()usage withasyncio.get_running_loop()in async socket operations and reaper startup.asyncio.create_task()/await asyncio.gather()and add guidance for running examples in an asyncio shell.