Repository navigation
Conversation
polserver now builds the ScopeTree only in analysis mode and holds it in a std::unique_ptr. Compiler::analyze() always creates it, so the language server reads it with -> and needs no null checks.
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
native/polserverto , the head ofecompile-diagnostics-140b0dc4after polserver/polserver#988. ThatPR keeps master's compiler behaviour outside
Compiler::analyze(). It also storesCompilerWorkspace::scope_treeas astd::unique_ptrthatonly analysis mode creates.
The language server only reaches the workspace through
analyze(), so the tree always exists. The five files thatread it now use
workspace.scope_tree->instead ofworkspace.scope_tree., with no null checks.The polserver update also fixes a crash while typing: a
half-typed
case ( elem ) 5: xsegfaulted inDisambiguator::visit_case_dispatch_group.