fix: use --preload for Bun instead of --import#16
Merged
Conversation
- Added bunPreloadFlag constant using --preload flag for Bun runtime - Added branch in extraImports logic to use correct flag per runtime - Added test case verifying Bun uses --preload flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Details
Bun requires `--preload` as a positional argument (e.g., `--preload /path/to/file`) rather than `--import=/path/to/file` which is used for Node.js and Deno. This fix updates the plugin-command to properly handle Bun's CLI arguments.
Test
Added test case verifying that `buildRunnerCommand` produces `--preload /tmp/dom-setup.ts` for Bun runtime instead of `--import=`.