Skip to content

Support Multiple Trigger Chars - #7

Open
ryanramage wants to merge 5 commits into
podio:masterfrom
ryanramage:master
Open

Support Multiple Trigger Chars#7
ryanramage wants to merge 5 commits into
podio:masterfrom
ryanramage:master

Conversation

@ryanramage

Copy link
Copy Markdown

triggerChar can now be set as just a char, or an array of chars. The trigger char is passed as the last parameter to the onDataRequest callback.
All type and templates now include the type and trigger char.
this commit fixes #5

ryanramage and others added 5 commits December 16, 2011 11:08
triggerChar can now be set as just a char, or an array of chars. The trigger char is passed as the last parameter to the onDataRequest callback.
All type and templates now include the type and trigger char.
@auchenberg

Copy link
Copy Markdown
Contributor

Thanks for adding this. It could become quite powerful for tagging etc.

The only thing is the usage of jQuery.data which I would prefer if we could avoid. Guess we need to change the signature of addMention to accept the triggerChar as a param?

@cmer

cmer commented Feb 25, 2012

Copy link
Copy Markdown

+1 for this.

@j-hernandez

Copy link
Copy Markdown

+1

1 similar comment
@mneuhaus

Copy link
Copy Markdown

+1

@mneuhaus

Copy link
Copy Markdown

I think there is no real nice way to circumvent the usage of data.
Is this the only thing that prevents this PR?

@SteelBRS

Copy link
Copy Markdown

Ehrm, I can't get triggerChar to work with an array - tried:
triggerChar:['@','#']

Oh, this code isn't in the master branch yet - any way to access ryanramage's changes?

@ryanramage

Copy link
Copy Markdown
Author

@TorbenVesterager here is my fork: https://github.com/ryanramage/jquery-mentions-input . It is now a little out of date. You can try and merge all the this master branch in if you would like.

saiwong pushed a commit to sporttu/jquery-mentions-input that referenced this pull request Jan 4, 2014
@erswelljustin

Copy link
Copy Markdown

Hi everyone, just stumbled upon this, and its is great however I am having some issues, I need to make different .getJSON() calls if a user types in an @ or an # can some create a GIST to show how to do this I am sure I am not the only one struggling

@sawyu

sawyu commented Aug 20, 2014

Copy link
Copy Markdown

How to add triggerChar from button click in mentionInput? triggerChar is not from type ahead. It comes from button click.

@kockok

kockok commented Jun 7, 2015

Copy link
Copy Markdown

Is multiple triggers working now? I mean "@" for mentions and "#" for hashtags, both from different JSON sources.

@leizard

leizard commented Sep 10, 2015

Copy link
Copy Markdown

@kockok I have the exact same question

@WellMafra

Copy link
Copy Markdown

@kockok I have the exact same question²

@emashiq emashiq left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really amazing work. Love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Multiple Trigger Chars