Skip to content

fix: remove deprecated mututals_description from kalshi normalizer - #580

Merged
realfishsam merged 1 commit into
mainfrom
fix/443-kalshi-deprecated-field
May 24, 2026
Merged

realfishsam merged 1 commit into
mainfrom
fix/443-kalshi-deprecated-field

Conversation

@realfishsam

Copy link
Copy Markdown
Contributor

Fixes #443

@realfishsam

Copy link
Copy Markdown
Contributor Author

PR Review: VERIFIED

What This Does

Removes the deprecated mututals_description field from the Kalshi raw event interface, normalizer, and test fixtures. The event description now always falls back to deriveEventDescription() which synthesizes a description from the constituent market rules.

Blast Radius

  • Kalshi exchange: fetcher.ts (raw type), normalizer.ts (mapping logic)
  • Tests: exchange-normalizers.test.ts (fixture and assertion updated)
  • No unified type, OpenAPI, or SDK changes

Findings

No blocking findings. The change is clean and well-scoped:

  • Removes a field that was misspelled in the original Kalshi API (mututals vs mutuals), suggesting it was indeed deprecated/removed upstream.
  • Test is updated to verify the fallback path, confirming deriveEventDescription produces a coherent result from market rules.
  • No other code references mututals_description outside these files.

PMXT Pipeline Check

  • Field propagation: OK (removal only affects raw type, unified description still populated via fallback)
  • OpenAPI sync: OK (no BaseExchange.ts change)
  • Type safety: OK

Semver Impact

patch -- removes usage of a deprecated upstream field, no API contract change

Risk

  • If the Kalshi API still returns mututals_description on some events (i.e., not fully deprecated), those descriptions will now be silently ignored in favor of the derived description. This is acceptable since the derived description is the canonical fallback, but verify against live Kalshi responses.

@realfishsam
realfishsam merged commit b4fdee3 into main May 24, 2026
11 of 12 checks passed
@realfishsam
realfishsam deleted the fix/443-kalshi-deprecated-field branch May 24, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Response drift: kalshi — event.mututals_description field absent from live API (deprecated)

1 participant