You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
SDK drift: filterMarkets/filter_markets treat a market missing resolutionDate oppositely — included in TypeScript, excluded in Python #1555
When a resolutionDate filter criterion is supplied and the candidate market's resolutionDate/resolution_date is falsy/missing, TypeScript keeps the market in the result set (the guard short-circuits and no exclusion happens), while Python explicitly excludes it. Same filter criteria + same market data yields opposite inclusion decisions across languages. This is the same category of bug as already-filed #1524 (priceChange24h), but on a different field (resolutionDate) not mentioned by that or any other filed issue.
criteria.resolutionDate && market.resolutionDate short-circuits when the market's date is missing — the market is not rejected and proceeds to the remaining checks.
if not val: continue explicitly excludes the market from the results.
Expected
Both languages should apply the same rule for markets missing a resolution date under a resolutionDate filter — either both should keep them (treat filter as inapplicable) or both should exclude them.
Impact
Callers filtering markets by resolution-date range get silently different result sets in TypeScript vs. Python whenever some markets lack a resolution date (e.g. still-open/perpetual markets).
Additional context from duplicate #1969: independently confirms this same filterMarkets/filter_marketsresolutionDate inclusion/exclusion divergence via a Core-to-SDK surface coverage audit (rather than the SDK-drift audit that found this issue), and adds the core-side reference point: core/src/BaseExchange.ts:1434-1444 explicitly excludes markets with a missing resolutionDate (if (!resDate) return false), confirming Python's behavior matches core and TypeScript's is the outlier. A fix PR (#1990, "fix(ts-sdk): exclude markets missing resolutionDate in filterMarkets") is already open against #1969 and should be retargeted to this issue.
Activity
realfishsam commentedon Aug 10, 2026
Additional context from duplicate #1969: independently confirms this same
filterMarkets/filter_marketsresolutionDateinclusion/exclusion divergence via a Core-to-SDK surface coverage audit (rather than the SDK-drift audit that found this issue), and adds the core-side reference point:core/src/BaseExchange.ts:1434-1444explicitly excludes markets with a missingresolutionDate(if (!resDate) return false), confirming Python's behavior matches core and TypeScript's is the outlier. A fix PR (#1990, "fix(ts-sdk): exclude markets missing resolutionDate in filterMarkets") is already open against #1969 and should be retargeted to this issue.Generated by Claude Code