Repository navigation
Fix/core edge cases - #116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
frameloop="demand". An idle scene never ran the frames that recentering needs to wait and ease back. Input axes now report that they are still moving.PanTiltandKlipp.updatepass that on, so the loop keeps going until the axis is back at center.InputControlleralso invalidates on pointer events that feed the axes: dragging, touch and pointer lock.enabled. Going fromstandbyordisabledback toenableddidn't write the shot when it hadn't changed, so the camera stayed where it was left. Re-enabling now always writes the current shot.<Klipp>invalidates when itsmodeprop changes.Each fix has a regression test.
API cleanup
groups(Sequencer,MixingCamera,StateDrivenCamera,ClearShot) andcameraState.mixare no longer exported. They aren't finished or tested enough to be public yet. The code and its tests stay in the repo.BlendHints.inheritPositionandBlendHints.screenSpaceAimWhenTargetsDiffer. Neither was implemented. The remaining flags keep their bit values.