Repository navigation
Remove built-in ThemeSeeds in favor of consumer components - #714
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the built-in
ThemeSeedsselector and seed table now owned by the design-system documentation. This is the counterpart to pmndrs/design-system#73, using the consumer components API from #713.Keep the shared theme hooks, footer controls and stored preset support used by the local component. Rewrite the persistence browser tests against remaining documentation pages. A patch changeset records the removal and consumer configuration migration; design-system was the only consumer.
Evidence
After: all four are removed; design-system owns its interactive and static renderers.
pnpm run lgtm: 656 tests passed, 4 skipped; types, lint, formatting and registry validation passed.pnpm run LGTM: passed on 94a141f; 656 unit tests passed (4 skipped), all 118 Playwright tests passed, including Purple and Lime persistence at mobile and desktop widths. Four-axis review found no issues requiring changes.Merge Danger
Door: two-way
The change is reversible and ships as a patch: design-system was the only consumer and is migrated in the linked PR.
Blast Radius: consumers
MDX using
<ThemeSeeds />must register its own component. The design-system counterpart now provides both renderers and stays pinned to docs 4.25.0 until a separate upgrade. Existing theme preferences and generic consumer components remain supported. The authoring URL redirect applies to Next server deployments; static exports do not apply Next redirects.