Ability to hide row or column totals#167
Open
SplitaxiDimi wants to merge 3 commits intoplotly:masterfrom
Open
Conversation
Added two boolean props to control whether row or col totals should be rendered
Added boolean props hideColTotals and hideRowTotals to control whether column or row totals should be rendered or screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where having row or column totals is meaningless. For example, consider a pivot table that displays a breakdown of accounts where each account contains balances in a different currency. Amounts in different currencies cannot be added so there should be no totals (or row) column displayed in the pivot table.
The caller should be able to customize whether it is the column, the row totals or both that need to be hidden.
Added boolean props named hideRowTotals and hideColTotals that can be passed in PivotTableUI like in the example below:
_```
<PivotTableUI
cols={selectedPivotCols}
rows={selectedPivotRows}
aggregatorName={selectedPivotAggregatorName}
vals={selectedPivotVals}
data={data}
onChange={changePivot}
hideRowTotals={selectedPivotCols.includes('Currency')}
hideColTotals={selectedPivotRows.includes('Currency')}
/>