Repository navigation
Conversation
camdecoster
reviewed
Nov 16, 2026
| test-optional: | ||
| name: Optional tests (Python ${{ matrix.python-version }}) | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-24.04 |
Contributor
There was a problem hiding this comment.
Could you add a comment stating why this is necessary and maybe a TODO to switch back to ubuntu-latest in the future?
| - Fix color utilities mutating the list of colors passed to them [[#5836](https://github.com/plotly/plotly.py/pull/5836)], with thanks to @Enesuygurs for the contribution! | ||
|
|
||
| ### Updated | ||
| - Removed Python 3.8 and Python 3.9 support. plotly.py now requires Python 3.10 or later [[#5883](https://github.com/plotly/plotly.py/pull/5883)] |
Contributor
There was a problem hiding this comment.
Suggested change
| - Removed Python 3.8 and Python 3.9 support. plotly.py now requires Python 3.10 or later [[#5883](https://github.com/plotly/plotly.py/pull/5883)] | |
| - Remove Python 3.8 and Python 3.9 support. plotly.py now requires Python 3.10 or later. [[#5883](https://github.com/plotly/plotly.py/pull/5883)] |
| scikit-learn | ||
| scipy==1.9.1 | ||
| setuptools<=81 | ||
| # geopandas pin also requires a transitive dependency pin for python>=3.10 |
Contributor
There was a problem hiding this comment.
Could you clarify this comment? I'm confused as to what you mean.
Comment on lines
+52
to
+54
| "matplotlib", | ||
| "contourpy>=1.3.3; python_version>='3.14'", | ||
| "kiwisolver>=1.4.9" |
Contributor
There was a problem hiding this comment.
Why was this change required?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops python 3.8 and 3.9 support.
The test matrices are updated accordingly.
This unblocks the dependabot updates that need Python 3.10 or later: