-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update plotly.js to v4.0.0-rc.0
#5673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emilykl
wants to merge
12
commits into
v7.0
Choose a base branch
from
update-plotlyjs-v4.0.0-rc.0
base: v7.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57,140
−169,222
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8bcb5e0
update plotly.js version to v4.0.0-rc.0 and run codegen
emilykl 9419595
rebuild FigureWidget and Jupyter extension
emilykl 52bbe59
remove all references to mapbox subplots and trace types in manually-…
emilykl 72286db
remove mapbox references from templates
emilykl 960ffa9
update tests to remove mapbox references (change to map where relevant)
emilykl 38988a0
remove mapbox references from codegen and rerun codegen
emilykl fa2b7da
delete removed config keys from offline.py
emilykl 3b1b7e0
mapbox -> map in figure factory README
emilykl 3a76e7d
remove SrcValidator
emilykl a293de3
remove references to Stream
emilykl ed0966c
remove references to showLink and linkText
emilykl 49f3825
update ColorValidator for new color processing in plotly.js 4.0
emilykl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ColorValidatorwill need to be updated to remove the references and regex checks forhsvsince that got removed. The regex patterns will also need to be updated to match the new color specifier support.