feat: Replace country-regex with country-iso-search#7856
Conversation
There was a problem hiding this comment.
@camdecoster Can you add a comment explaining why these custom codes are needed?
There was a problem hiding this comment.
Yeah, that's a good idea.
|
@camdecoster Are any user-facing changes expected as part of this switch (i.e. either country names/codes which were accepted previously and now are not, or vice-versa)? |
camdecoster
left a comment
There was a problem hiding this comment.
@emilykl there could be some strings that matched before that don't anymore, but that should be very few. I added a bunch of aliases in the new library that should cover most versions of country names.
On the other side, there a lot of new aliases that will match (including the flags). Overall, I think it's a new improvement, even if there are a few regressions (which can be fixed in updates to the new library).
There was a problem hiding this comment.
Yeah, that's a good idea.
|
@camdecoster Cool, no objections, just wanted to make sure it's clear what the impact will be in practice. |
Description
Replace
country-regexlibrary withcountry-iso-search.Part of #7026.
Changes
Testing
geo_country-namesmock in Plotly devtoolsNotes
country-iso-searchis a new Plotly maintained librarycountry-regexwas derived from a GPL-licensed source