Skip to content

feat: generate GitLab CI/CD config using a subtemplate - #243

Open
erral wants to merge 19 commits into
mainfrom
erral-gitlab-subtemplate
Open

erral wants to merge 19 commits into
mainfrom
erral-gitlab-subtemplate

Conversation

@erral

@erral erral commented May 29, 2025

Copy link
Copy Markdown
Member

As an alternative to #239 in this PR we add the GitLab CI/CD config as a subtemplate

@erral
erral requested review from ericof and pbauer as code owners May 29, 2025 14:35

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ci_gitlab/README.md needs some love. I think @ericof had an idea of how to generate all READMEs from boilerplate, but I'm not sure where that is at.

Comment thread news/243.feature Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much empty, so sad. 😭

@pbauer
pbauer requested a review from Gomez June 7, 2025 16:29
- apk add --no-cache make bash python3 ncurses openssh-client-common git
script:
- cd backend
- make check

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the check-target in the Makefile? Do you mean make lint?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I meant make lint. I had an older version of cookieplone-templates in place where make check was the command, sorry about that :(

@pbauer pbauer Jun 7, 2025 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only change the - to a / in the Makefile. The Makefiles in project_settings and classic_project_settings are not identical, so this is not ok.
It might be best to have one Makefile for both (as a subtemplate?) and make some targets conditional and the separator also conditional.

@erral

erral commented Jul 23, 2025

Copy link
Copy Markdown
Member Author

I have reworked this, reviewed and added tests.

The only thing that I don't like is overwriting the Makefile to modify the docker image name.

@pbauer suggested a way to address it creating a subtemplate for Makefiles, but I haven't checked it yet.

@acsr

acsr commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

I would be great if we can push this or the other #239 through the door.

I am not sure which one is worth testing currently. I would be nice if @ericof or @erral can give a flag if this is still worth a try.

This progress would also fix #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants