Repository navigation
[6.1.x] Build test images locally instead of pushing them - #228
Merged
Merged
Conversation
The test job pushed the builder and prod-config images to Docker Hub so the main image could build FROM them, which needs registry credentials. Workflows triggered by Dependabot or by forks do not get Actions secrets, so the job failed at the login step on those pull requests. Drop the Buildx setup so the default builder (docker driver) keeps each image in the runner's local image store, and remove the login, the pushes, the pull and the DOCKER_HUB environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the
6.2.xtest-workflow change to6.1.x.The
testjob pushed the builder and prod-config images to Docker Hub so the main image could buildFROMthem, which needs registry credentials. Workflows triggered by Dependabot do not get Actions secrets, so the job fails at the login step on #226.The job now builds all three images with the default
docker-driver builder, keeping them in the runner's local image store, and drops the login, the pushes, thedocker pulland theDOCKER_HUBenvironment. The commit is a clean cherry-pick; the only difference between the two branches'test.ymlis the branch trigger.#226 will need a rebase after this merges.