Paper saving (removal of page top/bottom margin) and some fixes#13
Open
gajdusek wants to merge 4 commits into
Open
Paper saving (removal of page top/bottom margin) and some fixes#13gajdusek wants to merge 4 commits into
gajdusek wants to merge 4 commits into
Conversation
Configurable by option "Margin Reduction" (MarginReductionType in PPD): - None - Top margin - Bottom margin - Top & Bottom margins (default)
- CUPS in Debian based distributions (including Raspbian) fails to load gzipped PPD files from /usr/share/cups/ Note: gzipped PPD files in /usr/share/ppd/ work - Compressing of PPD files saves very little disk space - PPD files shipped by Debian seem to be not gzipped
|
@plinth666 are you still maintaining this repo, or if not is there a fork that you recommend? |
doryza
approved these changes
Jul 27, 2018
plinth666
requested changes
May 10, 2019
| totalBytes = bs->bytesPerRow * bs->currentRow; | ||
| bs->currentRow = 0; | ||
| memset(bs->rawData, 0, totalBytes); | ||
| static void bufferscan_reset(t_bufferscan *bs) { |
Owner
There was a problem hiding this comment.
Most of these changes are whitespace changes and don't add or fix anything in the existing code.
I don't know if this was intentional or not, but perhaps you'd like to limit your PR to material changes in the code base. Perhaps this was done by a pretty printing editor and you weren't aware? Consider excluding this file from the PR.
| * abstraction takes away from the readability. | ||
| */ | ||
| typedef struct t_bufferscan { | ||
| int bytesPerRow; |
| struct command | ||
| { | ||
| int length; | ||
| struct command { |
|
|
||
| struct settings_ | ||
| { | ||
| struct settings_ { |
|
Any chance of getting a PPD with the margin reduction? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
my use case requires the roll is being cut just after the output, rather than continue printing until end of configured paper height (e.g. 200mm). I called this feature "Margin Reduction". It's called Paper Reduction in official Epson drivers. My implementation just throws away blank rows on page top and/or bottom.
Additionally, I observed that CUPS web administration breaks in case a gzipped PPD file is present in
/usr/share/cups/(at least Debian 7 a 9 is affected). I modified makefile to not gzip PPD files.I also unified formatting of C source as I had difficulties to work with mixed tabs/spaces indentation.
Let me know if I should break this in multiple pull requests.
Petr