Skip to content

feat: eu guarantee label - #3781

Draft
maxiroellplenty wants to merge 33 commits into
stablefrom
feat/guaranteelabel
Draft

feat: eu guarantee label #3781
maxiroellplenty wants to merge 33 commits into
stablefrom
feat/guaranteelabel

Conversation

@maxiroellplenty

@maxiroellplenty maxiroellplenty commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

All changes meet the following requirements

  • Changelog entry was added
  • Changes have been documented
  • Changes have been tested by the author
  • Changes have been tested by the reviewer
  • Changes to SCSS have been accounted for in plentyShop LTS Modern
    AB#201062
    @plentymarkets/plentyshop

@maxiroellplenty
maxiroellplenty requested a lite review from Copilot August 10, 2026 13:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 43 changed files in this pull request and generated no new comments.

Suppressed comments (2)

resources/views/Widgets/Item/GuaranteeLabelWidget.twig:18

  • In widget preview contexts, item/item.documents[0].data may be undefined; setting itemData = item.documents[0].data unconditionally can throw and break the preview. Only read item.documents[0].data when not in preview and when it is defined, and initialize brand/model to empty strings otherwise.
    resources/js/src/app/components/basket/list/BasketListItem.vue:240
  • isGuaranteeLabelVisible() dereferences basketItem.variation.data.item.manufacturer.name without checking that manufacturer exists. If an item has no manufacturer, this will throw and break rendering even when the guarantee label is disabled.
            return this.isDataFieldVisible("basket.item.guaranteeLabel") &&
                !!(this.basketItem.variation.data.item.manufacturer.name && this.basketItem.variation.data.variation.model);
        },

@maxiroellplenty
maxiroellplenty marked this pull request as draft August 13, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants