Skip to content

fix(logger): default to production mode for bundled binaries #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amondnet merged 2 commits into from
Jan 29, 2026
Merged

fix(logger): default to production mode for bundled binaries #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
697be27
fix(logger): default to production mode for bundled binaries
amondnet Jan 29, 2026
8e95318
refactor(logger): simplify bundled binary detection logic
amondnet Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/logger/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,12 @@ const REDACT_PATHS = [
/**
* Determine if pretty printing should be enabled
* Auto-detects based on NODE_ENV
* Bundled binaries default to production mode (no pretty printing)
*/
function shouldUsePretty(): boolean {
Comment thread
amondnet marked this conversation as resolved.
const env = process.env.NODE_ENV ?? 'development'
// Check if running as bundled binary (Bun.embeddedFiles exists in compiled binaries)
const isBundled = typeof Bun !== 'undefined' && 'embeddedFiles' in Bun
const env = process.env.NODE_ENV ?? (isBundled ? 'production' : 'development')
return env !== 'production'
Comment thread
amondnet marked this conversation as resolved.
}

Expand Down