Skip to content

feat: remove mcp - #79

Merged
amondnet merged 1 commit into
mainfrom
feat/remove-mcp
Jan 16, 2026
Merged

feat: remove mcp#79
amondnet merged 1 commit into
mainfrom
feat/remove-mcp

Conversation

@amondnet

Copy link
Copy Markdown
Contributor

Summary

  • Remove PostToolUse hooks (format, lsp) from Claude settings
  • Remove external MCP servers (grep, deepwiki) from .mcp.json
  • Add code-please plugin with local directory source

Changes

  • .claude/settings.json: Remove hooks, add local plugin configuration
  • .mcp.json: Remove grep and deepwiki MCP server configurations

Test plan

  • Build passes
  • Plugin loads correctly from local directory

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the configuration of the development environment by removing obsolete or external dependencies and integrating a new local plugin. The changes aim to simplify the Claude settings by eliminating specific PostToolUse hooks and external MCP server entries, while simultaneously enabling a new code-please plugin sourced directly from the local file system. This shift promotes a more self-contained and controlled plugin management approach.

Highlights

  • Claude Settings Update: Removed PostToolUse hooks for format and lsp from .claude/settings.json, streamlining the plugin execution flow.
  • MCP Server Removal: Eliminated external MCP server configurations for grep and deepwiki from .mcp.json, simplifying the MCP server setup.
  • New Local Plugin Integration: Added the code-please plugin to the Claude settings, configured to load from a local directory source.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying code-please with  Cloudflare Pages  Cloudflare Pages

Latest commit: 56b328e
Status:🚫  Build failed.

View logs

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes PostToolUse hooks and external MCP servers, replacing them with a local code-please plugin for Claude integration. The configuration changes in .claude/settings.json and .mcp.json are correct and align with the PR's goal. The changes look good. A minor point of feedback is that the documentation for hooks in apps/docs/content/docs/2.guides/1.claude-code-hooks.md is now outdated. This could be addressed in a follow-up PR to avoid user confusion.

@codecov

codecov Bot commented Jan 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.27%. Comparing base (73446ab) to head (56b328e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   39.27%   39.27%           
=======================================
  Files          59       59           
  Lines        6503     6503           
=======================================
  Hits         2554     2554           
  Misses       3949     3949           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amondnet
amondnet merged commit ef9504a into main Jan 16, 2026
9 of 10 checks passed
@amondnet
amondnet deleted the feat/remove-mcp branch January 16, 2026 06:23
@passionfactory-bot passionfactory-bot Bot mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant