Clarifying the use of data parameter in sh_binary rule

[SpangleLabs]

We keep seeing folks uncertain on the usage of the data parameter inside sh_binary targets, and unsure how to call other binaries from sh_binary targets.

I think clarifying "Runtime data" to "Runtime dependencies" will improve this.

Though it could be useful to specify also that the built binary will be in the same location as the shell script, such that you can call a data dependency, diff-checker from the shell script with something along these lines:

bashSource="$(dirname "$(readlink -f "$0")")"
"$bashSource/diff-checker"

(I'm also not sure whether that's the most effective way to get the current path and call the data dependency)

[peterebden]

Possibly yes, although I think we should be cautious with the use of "dependencies"; it's a term we use fairly heavily in Please which generally means build-time dependencies (with some variations on it, it's not always 100% clear or consistent). data is pretty consistently used as the argument meaning "runtime data", which may not be super well named (we really matched Blaze on it and didn't think that much).

Technically it's very easy to 'rename' an argument by adding an alias; conversely I'm nervous about making the shell plugin call something runtime_deps that other plugins call data. If that's a change we want to make, I think we would want that to be consistent.