Preamble: open .pex file from its canonical path#292
Merged
chrisnovakovic merged 1 commit intoplease-build:masterfrom Dec 4, 2025
Merged
Preamble: open .pex file from its canonical path#292chrisnovakovic merged 1 commit intoplease-build:masterfrom
chrisnovakovic merged 1 commit intoplease-build:masterfrom
Conversation
`argv[0]` might look like a relative path without actually existing relative to the current working directory - this is the case if (e.g.) the .pex file has been copied into a directory in `PATH` and the shell's `PATH` search behaviour is being relied upon to locate the .pex file. Get the canonical path to `argv[0]` before attempting to open it and read the preamble configuration within it.
toastwaffle
reviewed
Dec 4, 2025
kavya-chopra
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
argv[0]might look like a relative path without actually existing relative to the current working directory - this is the case if (e.g.) the .pex file has been copied into a directory inPATHand the shell'sPATHsearch behaviour is being relied upon to locate the .pex file. Get the canonical path toargv[0]before attempting to open it and read the preamble configuration within it.