Fix interpreter path in in-repo interpreter test#282
Merged
chrisnovakovic merged 1 commit intoplease-build:masterfrom Dec 1, 2025
Merged
Fix interpreter path in in-repo interpreter test#282chrisnovakovic merged 1 commit intoplease-build:masterfrom
chrisnovakovic merged 1 commit intoplease-build:masterfrom
Conversation
The in-repo interpreters were moved from `third_party/cpython/lib` to `third_party/cc/cpython` in please-build#277, but the interpreter directory path in `//test:interpreter_not_included_test` wasn't also updated, so the test still passes even if please_pex erroneously packs the in-repo interpreter into the .pex file. Update the path to fix the test.
toastwaffle
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-repo interpreters were moved from
third_party/cpython/libtothird_party/cc/cpythonin #277, but the interpreter directory path in//test:interpreter_not_included_testwasn't also updated, so the test still passes even if please_pex erroneously packs the in-repo interpreter into the .pex file. Update the path to fix the test.