Skip coverage tracer import test on FreeBSD#275
Merged
chrisnovakovic merged 1 commit intoplease-build:masterfrom Nov 17, 2025
Merged
Skip coverage tracer import test on FreeBSD#275chrisnovakovic merged 1 commit intoplease-build:masterfrom
chrisnovakovic merged 1 commit intoplease-build:masterfrom
Conversation
There is no pre-built coverage wheel for FreeBSD on PyPI, so python-rules' built-in test runners have to fall back on the pure-Python tracing implementation on FreeBSD. Don't run the `tracer` import test in `//test:python3_coverage_test` on FreeBSD - we expect it to fail. Fixes please-build#274.
toastwaffle
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no pre-built coverage wheel for FreeBSD on PyPI, so python-rules' built-in test runners have to fall back on the pure-Python tracing implementation on FreeBSD. Don't run the
tracerimport test in//test:python3_coverage_teston FreeBSD - we expect it to fail.Fixes #274.