Remove cx-Oracle import test#271
Merged
chrisnovakovic merged 1 commit intoplease-build:masterfrom Oct 29, 2025
Merged
Conversation
`//test:cx_oracle_darwin_build_test` just ensures that cx-Oracle is importable and defines a `__version__` attribute. The test name implies that the build process for cx-Oracle itself - specifically on Darwin - is what matters in this test, although it's not clear why: the test predates Please's plugin architecture, and was inherited from the main Please repo. cx-Oracle has been abandoned since 2022 [1] and hasn't had a new version published on PyPI since 2021 [2]. The final version only has pre-built wheels available for Python <= 3.10 manylinux SOABIs, so pip has to build it from source for the vast majority of SOABIs. It's not clear why this is a price worth paying any more, so remove it (and the test that depends on it). [1] https://oracle.github.io/python-cx_Oracle/ [2] https://pypi.org/project/cx-Oracle/8.3.0/
toastwaffle
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//test:cx_oracle_darwin_build_testjust ensures that cx-Oracle is importable and defines a__version__attribute. The test name implies that the build process for cx-Oracle itself - specifically on Darwin - is what matters in this test, although it's not clear why: the test predates Please's plugin architecture, and was inherited from the main Please repo.cx-Oracle has been abandoned since 2022 [1] and hasn't had a new version published on PyPI since 2021 [2]. The final version only has pre-built wheels available for Python <= 3.10 manylinux SOABIs, so pip has to build it from source for the vast majority of SOABIs. It's not clear why this is a price worth paying any more, so remove it (and the test that depends on it).
[1] https://oracle.github.io/python-cx_Oracle/
[2] https://pypi.org/project/cx-Oracle/8.3.0/