[WIP] Android asset consolidation#861
Merged
Merged
Conversation
…nAnimation remains
# Conflicts: # android/player/src/androidTest/kotlin/com/intuit/playerui/android/renderer/HydrationScopeTest.kt # android/player/src/main/kotlin/com/intuit/playerui/android/asset/SuspendableAsset.kt # android/player/src/main/kotlin/com/intuit/playerui/android/compose/ComposableAsset.kt # maven-lock.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## player-1-dot-zero #861 +/- ##
========================================
========================================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncHydrationTrackerPluginnow works with both XML and Compose assetsonHydrationStarted/onHydrationCompletehooks fire across the entire tree, including ComposableAsset children.hydrationScopeon rehydrate and cancelled on re-render.SuspendableAssetandDecodableAssetcollapsed intoRenderableAssetSuspendableAssetis deprecated; its async/suspending render API is now built into the base RenderableAsset class.DecodableAssetis also deprecated in favor of RenderableAsset — typed decoding from the asset node is part of the base class via the constructor's serializer.ComposableAssetis the only specialization that remains, and it extendsRenderableAssetdirectly.💥 Breaking — RenderableAsset API 💥
fun CoroutineScope.hydrate(view: View, data: Data).val dataproperty access is removed; usesuspend fun getData().child.render(parent.requireContext(), styles)extension family withinflate(child, container, styles). The new API handles render tracker registration, hydration scoping, and view insertion in one call.AnyAssetis now a typealias forRenderableAsset<*>and can be used to declare data types that are expected to be assets.Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?