-
Notifications
You must be signed in to change notification settings - Fork 0
Add profiler plugin for each platform #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tmarmer
wants to merge
10
commits into
mobile-devtools
Choose a base branch
from
profiler-plugin
base: mobile-devtools
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
01a1554
rewrite profiler plugin. add kotlin implementation
tmarmer fb9cd94
fix build issues for profiler plugin
tmarmer 550e064
fix mobile profiler plugin. update profiler plugin view to use flame …
tmarmer abedb3b
add basic rendering for profiler data
tmarmer 3c49a0e
centralize getNowTime and mock its usage
tmarmer 091bf62
return to using rootNode in plugin. code cleanup
tmarmer c4f59b4
add raw data tab to profiler plugin
tmarmer 1df221c
add clear option for profiler
tmarmer 06811be
split swift implementation into swiftui and ios plugins
tmarmer 2190602
update snapshots and fix lint issues
tmarmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export const getNowTime = globalThis.performance | ||
| ? () => globalThis.performance.now() | ||
| : () => Date.now(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| export { generateUUID } from "./uuid"; | ||
| export { genDataChangeTransaction } from "./genDataChangeTransaction"; | ||
| export { getNowTime } from "./getNowTime"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| load("@npm//:defs.bzl", "npm_link_all_packages") | ||
| load("@rules_player//javascript:defs.bzl", "js_pipeline") | ||
| load("//helpers:defs.bzl", "NATIVE_BUILD_DEPS", "tsup_config", "vitest_config") | ||
|
|
||
| npm_link_all_packages(name = "node_modules") | ||
|
|
||
| tsup_config(name = "tsup_config") | ||
|
|
||
| vitest_config(name = "vitest_config") | ||
|
|
||
| js_pipeline( | ||
| package_name = "@player-devtools/profiler-plugin", | ||
| build_deps = NATIVE_BUILD_DEPS, | ||
| native_bundle = "ProfilerDevtoolsPlugin", | ||
| deps = [ | ||
| ":node_modules/@player-devtools/messenger", | ||
| ":node_modules/@player-devtools/plugin", | ||
| ":node_modules/@player-devtools/types", | ||
| "//:node_modules/@devtools-ui/plugin", | ||
| "//:node_modules/@player-ui/player", | ||
| "//:node_modules/@types/uuid", | ||
| "//:node_modules/dequal", | ||
| "//:node_modules/dset", | ||
| "//:node_modules/immer", | ||
| "//:node_modules/uuid", | ||
| "//:node_modules/tapable-ts", | ||
| ], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "name": "@player-devtools/profiler-plugin", | ||
| "version": "0.0.0-PLACEHOLDER", | ||
| "main": "src/index.ts", | ||
| "dependencies": { | ||
| "@player-devtools/messenger": "workspace:*", | ||
| "@player-devtools/plugin": "workspace:*", | ||
| "@player-devtools/types": "workspace:*" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
performanceisn't available on the ios and kotlin integrations, so it's preferred for accuracy butDate.nowstill works.