feat: add Listbox component for single-select value pickers - #25
Open
RobertJoonas wants to merge 1 commit into
Open
feat: add Listbox component for single-select value pickers#25RobertJoonas wants to merge 1 commit into
RobertJoonas wants to merge 1 commit into
Conversation
Dropdown's menu semantics (role="menu"/"menuitem") don't fit picking a value for a form - that's an ARIA listbox pattern instead. Listbox renders a hidden form field and instantly updates the trigger's label on selection, ahead of any phx-change round-trip, while keeping the same Floating UI positioning and keyboard navigation as Dropdown. Also adds a demo docs page with live examples, Wallaby coverage, and an Introduction page entry.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropdown's menu semantics (role="menu"/"menuitem") don't fit picking a value for a form - that's an ARIA listbox pattern instead. Listbox renders a hidden form field and instantly updates the trigger's label on selection, ahead of any phx-change round-trip, while keeping the same Floating UI positioning and keyboard navigation as Dropdown.
Also adds a demo docs page with live examples, Wallaby coverage, and an Introduction page entry.