Load the version from shared context if set#101
Merged
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
changed the title
ShogunPanda
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
World resolves its deployment version from the environment (
PLT_WORLD_DEPLOYMENT_VERSIONorPLT_DEPLOYMENT_VERSION) and falls back to the runtime shared context, instead of reading the pod's plt.dev/version label via the Kubernetes API. This drops the pods:get RBAC the API read required, and lets the version arrive after startup: if it was not known at boot (ICC unreachable), World starts atlocaland latches the real version on the next queue read once it is pushed to the shared context, with no restart. Standalone/local dev still falls back tolocal.While the version is still unresolved (
local) in Kubernetes, enqueuing is refused so a run is never pinned tolocal(its messages would not route to the ICC-registered handlers); the caller retries until the version lands.Adds @platformatic/globals to read the shared context; it degrades to a no-op outside a runtime.